WIP: Facilitate playerbots as seller and buyer#9
Draft
icemansparks wants to merge 4 commits intomerkerhoodfrom
Draft
WIP: Facilitate playerbots as seller and buyer#9icemansparks wants to merge 4 commits intomerkerhoodfrom
icemansparks wants to merge 4 commits intomerkerhoodfrom
Conversation
Add configuration option to use playerbots as auction house bots by querying their GUIDs from the database based on account name prefix. Fallback to configured GUID list or account-based character query if playerbots are not used. Improve error handling and logging for invalid GUIDs and missing configurations. This enables more flexible bot management and easier integration with playerbot accounts.
Replace the local vector with a global set (gBotsId) to store bot GUIDs, ensuring uniqueness and more efficient lookups. Clear gBotsId at the start to avoid stale data. Update variable names for consistency and clarity. Add debug logging when inserting GUIDs from configuration. Remove redundant code that inserted GUIDs from a vector to the set. These changes improve performance, maintainability, and debugging of bot GUID management.
Remove redundant calls to LoadBotGUIDs() for each faction config and replace iteration over bot GUIDs with direct use of gBotsId. This streamlines the PopulateBots function by avoiding unnecessary data loading and relying on a pre-existing list of bot IDs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.