-
Notifications
You must be signed in to change notification settings - Fork 1
use a recent model development run that wasnt produced for cmip #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use a recent model development run that wasnt produced for cmip #341
Conversation
…ol-configuration-files
…t-wasnt-produced-for-cmip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mo-nikosbaltas 😊
This branch does not need the changes from @NParsonsMO's branch from #324. Please would you create a new branch without the changes from @NParsonsMO's branch, then create a new PR.
(Edited to add that it looks like you might have created your branch from @NParsonsMO's branch, which is why you needed to keep pulling in changes from @NParsonsMO's branch)
ehogan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please ensure CMEW runs successfully (specifically the unittest job) before requesting a review.
|
Superseded by #350 |
|
Superseded by #350 |
Closes #306
PR creation checklist for the developer
<issue_number>above ☝️ been replaced with the issue number?mainbeen selected as the base branch?<issue_number>_<short_description_of_feature>?good first issuelabel) been added to the PR?Climate Model Evaluation Workflow (CMEW)project been added to the PR?Definition of Done for the developer
docdirectory) related to the change been updated appropriately, including the Quick Start section?PR creation checklist for the reviewer
<issue_number>above ☝️ been replaced with the issue number?mainbeen selected as the base branch?<issue_number>_<short_description_of_feature>?good first issuelabel) been added to the PR?Climate Model Evaluation Workflow (CMEW)project been added to the PR?Definition of Done for the reviewer
docdirectory) related to the change been updated appropriately, including the Quick Start section?