check_macro_chains to fail gracefully on FCM #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bruten-mo
approved these changes
Dec 15, 2025
Collaborator
james-bruten-mo
left a comment
james-bruten-mo
left a comment
There was a problem hiding this comment.
Sensible, cheers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary
On FCM we always fetched the latest version of SimSys_Scripts, but this means check_macro_chains will now always fail as the latest version has been updated to use git. Since people are still running rose-stem on FCM as part of finishing reviews and migrating I'm making the script fail in a more obvious and cleaner way in this case. I'm checking for fcm with the presence of "dependencies.sh" since this has been removed in favour of "dependencies.yaml" in the git repos.
Testing
The script currently fails like this: https://cylchub/services/cylc-review/view/jennifer.hickson?&suite=apps_trunk%2Frun1&no_fuzzy_time=0&path=log/job/1/macro_chains_checker/01/job.err
with my check the error now looks like this:
https://cylchub/services/cylc-review/view/jennifer.hickson?&suite=apps_trunk%2Frun5&no_fuzzy_time=0&path=log/job/1/macro_chains_checker/01/job.err
Checklist