Conversation
tom-j-h
left a comment
There was a problem hiding this comment.
- Update the adjoint_tests and linear_model iodef files so that W2 fields are not written out. This also includes splitting the iodef files into many small iodef files (to mirror the gungho_model iodef files) - this makes it easier to manage going forward.
Can't comment on the details as I don't know much about configuring XIOS, but following gungho_model is the right thing to do.
- Correct the diagnostics source code so that xios only tries to write out fields if they are listed in the iodef file. (32 bit does not work for writing out W2 fields).
- Update the plotting to plot winds in W3 rather than W2 (as W2 are no longer in the diagnostic file).
Changes make sense.
- Update the adjoint test parameters to avoid dividing by zero errors.
Discussed offline, all good. More realistic values for wind as well.
- Add 32bit and 64bit tests, and with a variety of compilers, to the rose stem tests for linear_model and adjoint_tests. For adjoint_tests, slightly different solver settings are required for 32bit and 64 bit.
Perfect, thank you, good to have the gnu_production_32-bit in there!
Solver settings are likely to need adjusting because of #123, but we can make changes to either this PR or that one depending on which goes in first.
stevemullerworth
left a comment
There was a problem hiding this comment.
All looks fine. Sci/tech has been completed, but sci/tech reviewer has to request addition to the sci/tech reviewers' list from SSD team to allow boxes to be ticked.
Added to queue for final test and commit.
Boxes now ticked! |
PR Summary
Sci/Tech Reviewer: @tom-j-h
Code Reviewer: @stevemullerworth
Enable the tangent linear and adjoint models to use 32 bit precision and test.
#111
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - linear_32bit/run7
Suite Information
Task Information
✅ succeeded tasks - 1151
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review