mosrs ticket 1048 - adding openmp directives to chunking of ukca full domain passing #172
Conversation
…ng openmp directive around chunking of full domain passing
|
Failed test: run_gungho_model_robert-moist-lam-BiP100x8-10x10_azspice_gnu_fast-debug-64bit @alanjhewitt - this always fails right and is a broken test, i.e. not an issue with this PR |
|
TCD email bouncing (??) - does anyone have the correct address? |
It does work, but this task times out almost every time it gets run. Hopefully it will get updated to either be a shorter test or request extra resourses. |
Sorry, looks like it's missing an "l" in tools in the template. It should be toolscollabdevteam@metoffice.gov.uk |
moved changes over from mosrs ticket 1048, these were related to adding openmp directive around chunking of full domain passing
PR Summary
Sci/Tech Reviewer:
Code Reviewer:
See https://code.metoffice.gov.uk/trac/lfric_apps/ticket/1048 for full details.
Aim of the ticket is to add optional openmp directives around the domain chunking in the full domain passing interface - ukca file: src/science/core/chemistry/ukca_chemistry_ctl_full_mod.F90
This will involve adding to the following psyclone scripts inside lfric_apps:
Current status is have omp directives off by default but they can be turned on with the following logic:
The use of the UKCA_FULL_CHUNK_OMP env variable is short term solution - a follow-up ticket/PR will be to add this as a namelist option but to keep things short and simple we have opted to keep the short-term solution in for this ticket (original plan prior to github migration).
Follow-up MOSRS ticket: https://code.metoffice.gov.uk/trac/lfric_apps/ticket/1082
This will become an GH issue / PR.
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - ngarch_ukca_openmp_chunking_ticket_1048/run1
Suite Information
Task Information
❌ failed tasks - 1
⌛ waiting tasks - 1
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review