Skip to content

New function space options for coordinate fields #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tommbendall wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

New function space options for coordinate fields #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a398b2b
update all nml files and unit-tests
tommbendall Jan 22, 2026
487faa6
keep Wchi for bubble tests
tommbendall Jan 22, 2026
f1d1cc5
these weren't picked up by upgrade macro
tommbendall Jan 22, 2026
3241a6b
fixes to solver and scintelapi
tommbendall Jan 23, 2026
bccbce2
remove workaround for vertical slice tests
tommbendall Jan 23, 2026
56ab18d
another contributor signing
tommbendall Jan 23, 2026
25904f0
set other apps to use Wtheta, and fix remaining failures
tommbendall Jan 25, 2026
f8abde9
change coordinate settings for planar tests with issues
tommbendall Jan 26, 2026
cfc3f16
increase TLM tolerance
tommbendall Jan 26, 2026
4a8d200
increase tolerance again
tommbendall Jan 26, 2026
0015b23
replace Wchi in kernels
tommbendall Jan 26, 2026
7ade22a
test tweak
tommbendall Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@
| james-bruten-mo | James Bruten | Met Office | 2025-12-09 |
| jennyhickson | Jenny Hickson | Met Office | 2025-12-10 |
| mo-marqh | mark Hedley | Met Office | 2025-12-11 |
| tommbendall | Thomas Bendall | Met Office | 2026-01-23 |
2 changes: 2 additions & 0 deletions applications/adjoint_tests/example/configuration.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ start_dump_filename='',
&finite_element
cellshape='quadrilateral',
coord_order=1,
coord_order_multigrid=1,
coord_space='Wchi',
coord_system='native',
element_order_h=0,
element_order_v=0,
Expand Down
2 changes: 2 additions & 0 deletions applications/gravity_wave/example/configuration.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ start_dump_filename = ''
&finite_element
cellshape = 'quadrilateral'
coord_order = 1
coord_order_multigrid = 1,
coord_space = 'Wchi',
coord_system = 'native'
element_order_h = 0
element_order_v = 0
Expand Down
4 changes: 3 additions & 1 deletion applications/gravity_wave/unit-test/kernel/compute_q_operator_kernel_mod_test.pf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ contains
subroutine setUp( this )

use finite_element_config_mod, only: cellshape_quadrilateral, &
coord_system_xyz
coord_system_xyz, coord_space_wchi
use feign_config_mod, only: feign_finite_element_config

implicit none
Expand All @@ -42,6 +42,8 @@ contains
cellshape=cellshape_quadrilateral, &
coord_order=0_i_def, &
coord_system=coord_system_xyz, &
coord_order_multigrid=1_i_def, &
coord_space=coord_space_wchi, &
element_order_h=1_i_def, &
element_order_v=1_i_def, &
rehabilitate=.true., &
Expand Down
4 changes: 3 additions & 1 deletion applications/gravity_wave/unit-test/kernel/initial_buoyancy_kernel_mod_test.pf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ contains
stretching_method_linear
use sci_chi_transform_mod, only : init_chi_transforms
use finite_element_config_mod, only : cellshape_quadrilateral, &
coord_system_xyz
coord_system_xyz, coord_space_wchi
use feign_config_mod, only : feign_base_mesh_config, &
feign_extrusion_config, &
feign_finite_element_config, &
Expand Down Expand Up @@ -60,6 +60,8 @@ contains
call feign_finite_element_config( &
cellshape=cellshape_quadrilateral, &
coord_order=0_i_def, &
coord_order_multigrid=1_i_def, &
coord_space=coord_space_wchi, &
coord_system=coord_system_xyz, &
element_order_h=0_i_def, &
element_order_v=0_i_def, &
Expand Down
2 changes: 2 additions & 0 deletions applications/gungho_model/example/configuration.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ start_dump_filename='',
&finite_element
cellshape='quadrilateral',
coord_order=1,
coord_order_multigrid=1,
coord_space='Wtheta',
coord_system='native',
element_order_h=0,
element_order_v=0,
Expand Down
2 changes: 2 additions & 0 deletions applications/gungho_model/lam_example/baroclinic/config_driver.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ lbc_filename='',
&finite_element
cellshape='quadrilateral',
coord_order=1,
coord_order_multigrid=1,
coord_space='Wtheta',
coord_system='native',
element_order_h=0,
element_order_v=0,
Expand Down
2 changes: 2 additions & 0 deletions applications/gungho_model/lam_example/baroclinic/config_lam.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ lbc_filename='lbc',
&finite_element
cellshape='quadrilateral',
coord_order=1,
coord_order_multigrid=1,
coord_space='Wtheta',
coord_system='native',
element_order_h=0,
element_order_v=0,
Expand Down
2 changes: 2 additions & 0 deletions applications/gungho_model/lam_example/straka/config_driver.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ lbc_filename='',
&finite_element
cellshape='quadrilateral',
coord_order=1,
coord_order_multigrid=1,
coord_space='Wtheta',
coord_system='native',
element_order_h=0,
element_order_v=0,
Expand Down
2 changes: 2 additions & 0 deletions applications/gungho_model/lam_example/straka/config_lam.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ lbc_filename='lbc',
&finite_element
cellshape='quadrilateral',
coord_order=1,
coord_order_multigrid=1,
coord_space='Wtheta',
coord_system='native',
element_order_h=0,
element_order_v=0,
Expand Down
2 changes: 2 additions & 0 deletions applications/jedi_lfric_tests/example/configuration.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ start_dump_filename='final_pert',
cellshape='quadrilateral',
coord_order=1,
coord_system='native',
coord_order_multigrid=1,
coord_space='Wchi',
element_order_h=0,
element_order_v=0,
rehabilitate=.true.,
Expand Down
2 changes: 2 additions & 0 deletions applications/jedi_lfric_tests/example_forecast/configuration.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ start_dump_filename='',
&finite_element
cellshape='quadrilateral',
coord_order=1,
coord_order_multigrid=1,
coord_space='Wchi',
coord_system='native',
element_order_h=0,
element_order_v=0,
Expand Down
2 changes: 2 additions & 0 deletions applications/jedi_lfric_tests/example_forecast_pseudo/configuration.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ stretching_method='smooth',
&finite_element
cellshape='quadrilateral',
coord_order=1,
coord_order_multigrid=1,
coord_space='Wchi',
coord_system='native',
element_order_h=0,
element_order_v=0,
Expand Down
2 changes: 2 additions & 0 deletions applications/jedi_lfric_tests/example_forecast_pseudo/configuration_op.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ stretching_method='smooth',
&finite_element
cellshape='quadrilateral',
coord_order=1,
coord_order_multigrid=1,
coord_space='Wchi',
coord_system='native',
element_order_h=0,
element_order_v=0,
Expand Down
2 changes: 2 additions & 0 deletions applications/jedi_lfric_tests/example_id_tlm_tests/configuration.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,8 @@ start_dump_filename='',
&finite_element
cellshape='quadrilateral',
coord_order=1,
coord_order_multigrid=1,
coord_space='Wchi',
coord_system='native',
element_order_h=0,
element_order_v=0,
Expand Down
2 changes: 2 additions & 0 deletions applications/jedi_lfric_tests/example_tlm_forecast_tl/configuration.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,8 @@ start_dump_filename='',
&finite_element
cellshape='quadrilateral',
coord_order=1,
coord_order_multigrid=1,
coord_space='Wchi',
coord_system='native',
element_order_h=0,
element_order_v=0,
Expand Down
2 changes: 2 additions & 0 deletions applications/jedi_lfric_tests/example_tlm_forecast_tl/configuration_op.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,8 @@ start_dump_filename='',
&finite_element
cellshape='quadrilateral',
coord_order=1,
coord_order_multigrid=1,
coord_space='Wchi',
coord_system='native',
element_order_h=0,
element_order_v=0,
Expand Down
2 changes: 2 additions & 0 deletions applications/jedi_lfric_tests/example_tlm_tests/configuration.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,8 @@ start_dump_filename='',
&finite_element
cellshape='quadrilateral',
coord_order=1,
coord_order_multigrid=1,
coord_space='Wchi',
coord_system='native',
element_order_h=0,
element_order_v=0,
Expand Down
2 changes: 2 additions & 0 deletions applications/jedi_lfric_tests/example_tlm_tests/configuration_dry.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,8 @@ start_dump_filename='',
&finite_element
cellshape='quadrilateral',
coord_order=1,
coord_order_multigrid=1,
coord_space='Wchi',
coord_system='native',
element_order_h=0,
element_order_v=0,
Expand Down
2 changes: 2 additions & 0 deletions applications/jedi_lfric_tests/example_tlm_tests/configuration_dry_relaxed.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ start_dump_filename='',
&finite_element
cellshape='quadrilateral',
coord_order=1,
coord_order_multigrid=1,
coord_space='Wchi',
coord_system='native',
element_order_h=0,
element_order_v=0,
Expand Down
2 changes: 2 additions & 0 deletions ...ns/jedi_lfric_tests/integration-test/algorithm/resources/algorithm_test_configuration.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ element_order_h=0,
element_order_v=0,
rehabilitate=.true.,
coord_order=1
coord_order_multigrid=1,
coord_space='Wchi',
coord_system='native'
/

Expand Down
2 changes: 1 addition & 1 deletion applications/jedi_lfric_tests/source/jedi_tlm_tests.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ program jedi_tlm_tests
character( str_def ) :: forecast_length_str
real( kind=r_def ) :: dot_product_1
real( kind=r_def ) :: dot_product_2
real( kind=r_def ), parameter :: absolute_tolerance = 1.0E-4_r_def
real( kind=r_def ), parameter :: absolute_tolerance = 3.0E-4_r_def
real( kind=r_def ) :: machine_tolerance
real( kind=r_def ) :: absolute_diff
real( kind=r_def ) :: relative_diff
Expand Down
2 changes: 2 additions & 0 deletions applications/jules/example/configuration.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ start_dump_filename='',
&finite_element
cellshape='quadrilateral',
coord_order=1,
coord_order_multigrid=1,
coord_space='Wchi',
coord_system='native',
element_order_h=0,
element_order_v=0,
Expand Down
2 changes: 2 additions & 0 deletions applications/lfric2lfric/example/configuration.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ element_order_h = 0,
element_order_v = 0,
rehabilitate = .true.,
coord_order = 1,
coord_order_multigrid = 1,
coord_space = 'Wchi',
/

&io
Expand Down
2 changes: 2 additions & 0 deletions applications/lfric_atm/example/configuration.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,8 @@ start_dump_filename='',
&finite_element
cellshape='quadrilateral',
coord_order=1,
coord_order_multigrid=1,
coord_space='Wchi',
coord_system='native',
element_order_h=0,
element_order_v=0,
Expand Down
2 changes: 2 additions & 0 deletions applications/lfric_coupled/example/configuration.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ start_dump_filename='',
&finite_element
cellshape='quadrilateral',
coord_order=1,
coord_order_multigrid=1,
coord_space='Wtheta',
coord_system='native',
element_order_h=0,
element_order_v=0,
Expand Down
2 changes: 2 additions & 0 deletions applications/linear_model/example/configuration.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ ls_filename='',
&finite_element
cellshape='quadrilateral',
coord_order=1,
coord_order_multigrid=1,
coord_space='Wchi',
coord_system='native',
element_order_h=0,
element_order_v=0,
Expand Down
2 changes: 2 additions & 0 deletions applications/linear_model/example_file/config_linear.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ ls_filename='ls',
&finite_element
cellshape='quadrilateral',
coord_order=1,
coord_order_multigrid=1,
coord_space='Wchi',
coord_system='native',
element_order_h=0,
element_order_v=0,
Expand Down
2 changes: 2 additions & 0 deletions applications/linear_model/example_file/config_nonlinear.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ start_dump_filename='',
&finite_element
cellshape='quadrilateral',
coord_order=1,
coord_order_multigrid=1,
coord_space='Wchi',
coord_system='native',
element_order_h=0,
element_order_v=0,
Expand Down
2 changes: 2 additions & 0 deletions applications/name_transport/example/configuration.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ element_order_h=0,
element_order_v=0,
rehabilitate=.true.,
coord_order=1,
coord_order_multigrid=1,
coord_space='Wchi',
coord_system='native'
vorticity_in_w1=.true.,
/
Expand Down
4 changes: 3 additions & 1 deletion applications/name_transport/unit-test/kernel/set_name_field_kernel_mod_test.pf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ contains
use extrusion_config_mod, only : method_uniform, &
stretching_method_linear
use finite_element_config_mod, only : cellshape_quadrilateral, &
coord_system_xyz
coord_system_xyz, coord_space_wchi
use feign_config_mod, only : feign_base_mesh_config, &
feign_extrusion_config, &
feign_finite_element_config, &
Expand Down Expand Up @@ -67,6 +67,8 @@ contains
call feign_finite_element_config( &
cellshape=cellshape_quadrilateral, &
coord_order=0_i_def, &
coord_order_multigrid=1_i_def, &
coord_space=coord_space_wchi, &
coord_system=coord_system_xyz, &
element_order_h=0_i_def, &
element_order_v=0_i_def, &
Expand Down
2 changes: 2 additions & 0 deletions applications/ngarch/example/configuration_bl.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,8 @@ surface_frac_ancil_path='vegetation/fractions_cci/qrparm.veg.frac.fixed',
&finite_element
cellshape='quadrilateral',
coord_order=1,
coord_order_multigrid=1,
coord_space='Wchi',
coord_system='native',
element_order_h=0,
element_order_v=0,
Expand Down
2 changes: 2 additions & 0 deletions applications/ngarch/example/configuration_casim.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,8 @@ surface_frac_ancil_path='vegetation/fractions_cci/qrparm.veg.frac.fixed',
&finite_element
cellshape='quadrilateral',
coord_order=1,
coord_order_multigrid=1,
coord_space='Wchi',
coord_system='native',
element_order_h=0,
element_order_v=0,
Expand Down
2 changes: 2 additions & 0 deletions applications/shallow_water/example/configuration.nml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,8 @@ start_dump_directory = ''
! These do not need changing
cellshape = 'quadrilateral'
coord_order = 1
coord_order_multigrid = 1
coord_space = 'Wchi'
coord_system = 'native'
element_order_h = 0
element_order_v = 0
Expand Down
4 changes: 3 additions & 1 deletion applications/shallow_water/unit-test/kernel/initial_geopot_kernel_mod_test.pf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ contains
feign_planet_config, &
feign_shallow_water_settings_config
use finite_element_config_mod, only : cellshape_quadrilateral, &
coord_system_xyz
coord_system_xyz, coord_space_wchi
use sci_chi_transform_mod, only : init_chi_transforms
use shallow_water_settings_config_mod, &
only : momentum_form_momentum, &
Expand All @@ -77,6 +77,8 @@ contains

call feign_finite_element_config( cellshape=cellshape_quadrilateral, &
coord_order=0_i_def, &
coord_order_multigrid=1_i_def, &
coord_space=coord_space_wchi, &
coord_system=coord_system_xyz, &
element_order_h=0_i_def, &
element_order_v=0_i_def, &
Expand Down
4 changes: 3 additions & 1 deletion applications/shallow_water/unit-test/kernel/initial_swe_buoyancy_kernel_mod_test.pf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ contains
feign_shallow_water_settings_config
use finite_element_config_mod, &
only : cellshape_quadrilateral, &
coord_system_xyz
coord_system_xyz, coord_space_wchi
use sci_chi_transform_mod, only : init_chi_transforms
use shallow_water_settings_config_mod, &
only : momentum_form_momentum, &
Expand All @@ -78,6 +78,8 @@ contains

call feign_finite_element_config( cellshape=cellshape_quadrilateral, &
coord_order=0_i_def, &
coord_order_multigrid=1_i_def, &
coord_space=coord_space_wchi, &
coord_system=coord_system_xyz, &
element_order_h=0_i_def, &
element_order_v=0_i_def, &
Expand Down
4 changes: 3 additions & 1 deletion applications/shallow_water/unit-test/kernel/initial_swe_tracer_kernel_mod_test.pf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ contains
feign_planet_config, &
feign_shallow_water_settings_config
use finite_element_config_mod, only : cellshape_quadrilateral, &
coord_system_xyz
coord_system_xyz, coord_space_wchi
use sci_chi_transform_mod, only : init_chi_transforms
use shallow_water_settings_config_mod, &
only : momentum_form_momentum, &
Expand All @@ -77,6 +77,8 @@ contains

call feign_finite_element_config( cellshape=cellshape_quadrilateral, &
coord_order=0_i_def, &
coord_order_multigrid=1_i_def, &
coord_space=coord_space_wchi, &
coord_system=coord_system_xyz, &
element_order_h=0_i_def, &
element_order_v=0_i_def, &
Expand Down
Loading
Loading