New function space options for coordinate fields#179
Draft
tommbendall wants to merge 12 commits intoMetOffice:mainfrom
Draft
New function space options for coordinate fields#179tommbendall wants to merge 12 commits intoMetOffice:mainfrom
tommbendall wants to merge 12 commits intoMetOffice:mainfrom
Conversation
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer:
This PR picks up on the new coordinate field namelist options from MetOffice/lfric_core#238.
To facilitate coordinate spaces with some level of continuity, the
assign_orography_fieldroutines have been altered. The coordinate fields are copied so that heights are not adjusted multiple times by different cells.The vast majority of changes involve the addition of the new namelist options into all of the required files.
Linked to MetOffice/lfric_core#238
Test branch: a link to show the action of the upgrade macro and KGOs can be found: https://github.com/tommbendall/lfric_apps/pull/1/changes
Code Quality Checklist
Testing
trac.log
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review