Skip to content

New function space options for coordinate fields#179

Draft
tommbendall wants to merge 12 commits intoMetOffice:mainfrom
tommbendall:TBendall/CoordSpace
Draft

New function space options for coordinate fields#179
tommbendall wants to merge 12 commits intoMetOffice:mainfrom
tommbendall:TBendall/CoordSpace

Conversation

@tommbendall
Copy link
Contributor

@tommbendall tommbendall commented Jan 22, 2026

PR Summary

Sci/Tech Reviewer:
Code Reviewer:

This PR picks up on the new coordinate field namelist options from MetOffice/lfric_core#238.

To facilitate coordinate spaces with some level of continuity, the assign_orography_field routines have been altered. The coordinate fields are copied so that heights are not adjusted multiple times by different cells.

The vast majority of changes involve the addition of the new namelist options into all of the required files.

Linked to MetOffice/lfric_core#238

Test branch: a link to show the action of the upgrade macro and KGOs can be found: https://github.com/tommbendall/lfric_apps/pull/1/changes

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Core rose-stem suite
  • If required (e.g. API changes) I have also run the LFRic Apps test suite using this branch
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@github-actions github-actions bot added the cla-required The CLA has not yet been signed by the author of this PR - added by GA label Jan 22, 2026
@tommbendall tommbendall added enhancement New feature or request Linked Core This PR is linked to a MetOffice/lfric_core PR KGO This PR contains changes to KGO macro This PR contains a metadata upgrade macro and removed cla-required The CLA has not yet been signed by the author of this PR - added by GA labels Jan 22, 2026
@github-actions github-actions bot added the cla-required The CLA has not yet been signed by the author of this PR - added by GA label Jan 22, 2026
@github-actions github-actions bot added cla-signed The CLA has been signed as part of this PR - added by GA and removed cla-required The CLA has not yet been signed by the author of this PR - added by GA labels Jan 23, 2026
@tommbendall tommbendall mentioned this pull request Jan 23, 2026
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed as part of this PR - added by GA enhancement New feature or request KGO This PR contains changes to KGO Linked Core This PR is linked to a MetOffice/lfric_core PR macro This PR contains a metadata upgrade macro

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant