Skip to content

Migrate jules pftparm metadata to jules shared#205

Draft
maggiehendry wants to merge 9 commits intoMetOffice:mainfrom
maggiehendry:migrate-jules_pftparm-metadata-to-jules-shared
Draft

Migrate jules pftparm metadata to jules shared#205
maggiehendry wants to merge 9 commits intoMetOffice:mainfrom
maggiehendry:migrate-jules_pftparm-metadata-to-jules-shared

Conversation

@maggiehendry
Copy link
Contributor

@maggiehendry maggiehendry commented Feb 1, 2026

PR Summary

Sci/Tech Reviewer:
Code Reviewer:

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Apps rose-stem suite
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

maggiehendry and others added 7 commits January 15, 2026 15:36
@maggiehendry
- jules_model_environment migrated to **lfric-jules-shared/jules-mo…
81807d0 
…del-environment**

  - As a result of the way lfric_coupled imports the component config files `jules_model_environment` cannot exist in two different components.
  - Added for now with "_lfric" appended to namelist to avoid overwiting Rivers config.
  - `lsm_id` has not been shared as no point until "_lfric" can be removed.
  - Trigger list added with "not_lfric" as a result of enumeration.
- `jules_surface` migrated to **lfric-jules-shared/jules-surface**.
  - Switches not available to LFRic triggered off (`l_jules_parent`) and made unavailable via code.
- **jules-lfric** contains related LFRic specific amendments to shared metadata.
@maggiehendry
Merge remote-tracking branch 'origin/stable' into 146-migrate-jules_m…
1b2bc2d 
…odel_environment-remainder-of-jules_surface-to-jules-shared
@maggiehendry
Merge branch 'MetOffice:main' into 146-migrate-jules_model_environmen…
6b92c6c 
…t-remainder-of-jules_surface-to-jules-shared
@maggiehendry
Merge branch 'MetOffice:main' into 146-migrate-jules_model_environmen…
8eaa8c7 
…t-remainder-of-jules_surface-to-jules-shared
@maggiehendry
Name added to contibutors.
454f4d5
@maggiehendry
Merge branch '146-migrate-jules_model_environment-remainder-of-jules_…
97ebca9 
…surface-to-jules-shared' of github.com:maggiehendry/lfric_apps into 146-migrate-jules_model_environment-remainder-of-jules_surface-to-jules-shared
@maggiehendry
Metadata urls updated with new location of online docs (not yet versi…
e793c05 
…on specific).
@github-actions github-actions bot added the cla-signed The CLA has been signed as part of this PR - added by GA label Feb 1, 2026
@maggiehendry
* JULES source set to local clone.
5e6b08d 
* `jules_pftparm` migrated to **jules-shared**.
* Hardwired values moved to upgrade macro.
* Unused items for now ignored.
* Plumbing in `jules_physics_init` incomplete and has an issue with the incorrect shape of the enumerated arrays - does not compile.
@maggiehendry
Merge remote-tracking branch 'origin/main' into migrate-jules_pftparm…
f463a24 
…-metadata-to-jules-shared (upgraded to include MetOffice#181)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@maggiehendry maggiehendry

Labels

cla-signed The CLA has been signed as part of this PR - added by GA

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@maggiehendry