Performance comparison and performance tests#214
Open
mo-marqh wants to merge 8 commits intoMetOffice:mainfrom
Open
Performance comparison and performance tests#214mo-marqh wants to merge 8 commits intoMetOffice:mainfrom
mo-marqh wants to merge 8 commits intoMetOffice:mainfrom
Conversation
ac59096 to
23420fa
Compare
23420fa to
1e58ea2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: @iboutle
Code Reviewer: @mo-alistairp
This branch first adds a performance configuration for a C896 test run triggered multiple times, to enable cross run variability to be analysed. this test is not run regularly, but is derived from the weekly C896 test so should remain safe to use.
Following the adoption of #82 & #176 it is possible to compare timer based output from December's Performance analysis package branch (https://code.metoffice.gov.uk/trac/lfric_apps/browser/main/branches/pkg/Share/r15393_kpi_benchmark) with the current
main.We cannot run with complicated decompositions across panels until #138. But, we can run with 4704 32x32 ranks.
Using a 720 timestep C896 run with 4704 ranks then a run can be analysed with the svn package branch and the main.
Comparing test results for the legacy package branch and the current
mainshows a significant discrepancy in the timestepping time, within predominantlyfast_physicswhich is fixed by setting
["namelist:physics", "configure_segments"], ".true."and allowing values of 0 for all segments (mis-configured in rose metadata)
mo-marqh@1e58ea2
this requires a macro, the results of the macro running on the code base are detailed in:
https://github.com/mo-marqh/lfric_apps/tree/performanceComparePostMacro
mo-marqh@16041eb
PKG branch from svn performance analysis Dec25 *1880s*
This branch, *2006s*
This branch, with configure segments 16 *1807s*
Code Quality Checklist
Testing
trac.log
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review