reducing post-processing of XIOS output#204
Open
mo-marqh wants to merge 2 commits intoMetOffice:mainfrom
Open
Conversation
github-actions
bot
added
the
cla-signed
27 tasks
…ing. functional switching; only post process on ugrid planar projected. XIOS3 compatibility.
mo-marqh
force-pushed
the
xios3-compatibility-stable3
branch
from
06cc787 to
4ed0042
Compare
EdHone
requested changes
Jan 12, 2026
Contributor
There was a problem hiding this comment.
Sci/Tech review
Overall a well-formatted change that dramatically reduces our dependency on file post-processing in the majority of cases which will enhance the resilience of our code. It's good that the flag for post-processing is decided on a file-by-file basis.
- Could you please re-name the PR to more accurately reflect the scope of the changes (i.e. reducing post-processing of XIOS output) as there are more changes that need to be made before we can run with XIOS3.
- It would also be good to see a side-by-side comparison of the NetCDF headers of output files (say from C12 NWP runs) to confirm that the contents are similar (this can be handled on the linked ticket in #lfric_apps#90)
- It would be nice to implement an integration test which confirm that the file format is correct when the frt scalar is incuded in the iodef.xml - I'm happy if you want to create this as a separate issue
mo-marqh
changed the title
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: @EdHone
Code Reviewer: @ericaneininger
This PR refactors the metadata manipulation that is currently done within a file post processing function.
Only one post processing operation remains, which is only needed in the edge case of a limited area model using projected coordinates. This may be able to be done with XIOS in future, but right now this remains a feature gap.
For all other metadata specifications, these are implemented using XIOS, and removed from post processing.
This also removes the need for MPI
init_wait()calls from most usage patterns.This change introduces a soft requirement for new XML configuration, forecast reference times will only be output if an appropriately named scalar is provided, normally through XML configuration files (see linked PR)
Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
style guidelines
readability of the code
Testing
using this branch
acceptable (e.g. kgo changes)
tests, unit tests, etc.)
and have been allocated to an appropriate testing group (i.e. the
developer tests are for jobs which use a small amount of compute resource
and complete in a matter of minutes)
trac.log
Test Suite Results - lfric_core - xios3-compatibility-stable3/run2
Suite Information
Task Information
✅ succeeded tasks - 372
Security Considerations
Performance Impact
performance measurements have been conducted
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy
(including attribution labels)
Documentation
confirmed that it builds correctly
PSyclone Approval
interface, optimisation scripts, LFRic data structure code) then please
contact the
tooscollabdevteam@metoffice.gov.uk
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review