Enable reading for cyclic data files using temporal controller#231
Open
EdHone wants to merge 9 commits intoMetOffice:mainfrom
Open
Enable reading for cyclic data files using temporal controller#231EdHone wants to merge 9 commits intoMetOffice:mainfrom
EdHone wants to merge 9 commits intoMetOffice:mainfrom
Conversation
Contributor
harry-shepherd
left a comment
There was a problem hiding this comment.
Just a couple of trivial changes
components/lfric-xios/integration-test/lfric_xios_cyclic_temporal_test.py
Outdated
Show resolved
Hide resolved
components/lfric-xios/integration-test/lfric_xios_cyclic_temporal_test.py
Outdated
Show resolved
Hide resolved
components/lfric-xios/integration-test/lfric_xios_cyclic_temporal_test.py
Outdated
Show resolved
Hide resolved
components/lfric-xios/integration-test/lfric_xios_cyclic_temporal_test.py
Outdated
Show resolved
Hide resolved
components/lfric-xios/integration-test/lfric_xios_cyclic_temporal_test.py
Outdated
Show resolved
Hide resolved
components/lfric-xios/integration-test/lfric_xios_temporal_test.py
Outdated
Show resolved
Hide resolved
components/lfric-xios/integration-test/lfric_xios_temporal_test.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks @harry-shepherd - all comments addressed in the latest commit |
Contributor
Author
|
I noticed something is wrong - the initial data is being read in for the timestep before the one it needs to be reading, as can be seen in the second plot above - reverting to draft to fix |
Contributor
Author
Contributor
Author
|
Requesting another sci -tech review from @harry-shepherd: The new plot above shows that we are getting the correct initial data now, when compared to the plot before |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR Summary
Sci/Tech Reviewer: @harry-shepherd
Code Reviewer: @mo-lucy-gordon
This PR enables the handling of cyclic data files(files which we start reading again from the beginning once we reach the end) by the new lfric-xios temporal controller. The contents of this PR are:
NonSync) which exercise this functionalityCode Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
style guidelines
readability of the code
Testing
using this branch
acceptable (e.g. kgo changes)
tests, unit tests, etc.)
and have been allocated to an appropriate testing group (i.e. the
developer tests are for jobs which use a small amount of compute resource
and complete in a matter of minutes)
Some plots from the LFRic-XIOS integration tests which show that the data is being correctly digested


trac.log
Test Suite Results - lfric_core - lfric_core-230-cyclic-read/run4
Suite Information
Task Information
✅ succeeded tasks - 372
Security Considerations
Performance Impact
performance measurements have been conducted
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy
(including attribution labels)
Documentation
confirmed that it builds correctly
PSyclone Approval
interface, optimisation scripts, LFRic data structure code) then please
contact the
tooscollabdevteam@metoffice.gov.uk
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review