Fix jedi config

[mo-rickywong]

PR Summary

Sci/Tech Reviewer: @ss421
Code Reviewer: @MatthewHambley

• Reworked Configuration Namelist Access API #175 causes non-test suite Jedi tests to break on finaliser calls to modeldb%config. This failure is on the clearance of linked list which have not been allocated/initialised. A protection is added to the finalising routine to catch this failure.

Code Quality Checklist

• I have performed a self-review of my own code
• My code follows the project's style guidelines
• Comments have been included that aid understanding and enhance the readability of the code
• My changes generate no new warnings
• All automated checks in the CI pipeline have completed successfully

Testing

• I have tested this change locally, using the LFRic Core rose-stem suite
• If required (e.g. API changes) I have also run the LFRic Apps test suite using this branch
• If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
• I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
• Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Security Considerations

• I have reviewed my changes for potential security issues
• Sensitive data is properly handled (if applicable)
• Authentication and authorisation are properly implemented (if applicable)

Performance Impact

• Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

• Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

• Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

• If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

• I understand this area of code and the changes being added
• The proposed changes correspond to the pull request description
• Documentation is sufficient (do documentation papers need updating)
• Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

• All dependencies have been resolved
• Related Issues have been properly linked and addressed
• CLA compliance has been confirmed
• Code quality standards have been met
• Tests are adequate and have passed
• Documentation is complete and accurate
• Security considerations have been addressed
• Performance impact is acceptable

[ss421]

Thanks for the update. The changes look good and Ive set up a jedi test suite with this branch via:

cylc vip -O mobbalt -n FixJediConfig \
  -S REF_LFRIC_CORE='"FixJediConfig"' \
  -S REPO_LFRIC_CORE='"https://github.com/mo-rickywong/lfric_core.git"'

with output here. I expect the tests to run as I have tested with a similar branch previously. Will approve when test complete. Tagging @matthewrmshin for visibility.

[ss421]

Testing is all green :-) handing over to @MatthewHambley

[matthewrmshin]

I've applied the branch of this PR to our failing daily workflow. Re-built jedi-lfric and re-triggered the failed ctest tasks. All passed. Double confirm the results by @ss421. Thanks.