Skip to content

Remove all usage of namelist collection object modeldb%configuration (Full Purge)#266

Draft
mo-rickywong wants to merge 47 commits intoMetOffice:mainfrom
mo-rickywong:IntermediateApiFullPurge
Draft

Remove all usage of namelist collection object modeldb%configuration (Full Purge)#266
mo-rickywong wants to merge 47 commits intoMetOffice:mainfrom
mo-rickywong:IntermediateApiFullPurge

Conversation

@mo-rickywong
Copy link
Contributor

@mo-rickywong mo-rickywong commented Feb 4, 2026

PR Summary

Sci/Tech Reviewer: N/A
Code Reviewer:

Technical infrastructure change, no change to major structure, SciTech not required.

Removes remain usage of configuration access that was missed before:

  • modeldb%configuration no longer initialised
  • Usage of configuration_mod should be swapped with config_loader_mod

Linked PRs

Blocking PR

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Core rose-stem suite
  • If required (e.g. API changes) I have also run the LFRic Apps test suite using this branch
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

mo-rickywong and others added 30 commits December 2, 2025 13:43
Co-authored-by: Matthew Hambley <MatthewHambley@users.noreply.github.com>
Co-authored-by: Matthew Hambley <MatthewHambley@users.noreply.github.com>
…f90.jinja

Co-authored-by: Matthew Hambley <MatthewHambley@users.noreply.github.com>
…f90.jinja

Co-authored-by: Matthew Hambley <MatthewHambley@users.noreply.github.com>
Co-authored-by: Matthew Hambley <MatthewHambley@users.noreply.github.com>
@github-actions github-actions bot added the cla-modified The CLA has been modified as part of this PR - added by GA label Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-modified The CLA has been modified as part of this PR - added by GA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants