Update rose-stem to extract MOCI and UM-related repos from Git#29
Open
ericaneininger wants to merge 2 commits intoMetOffice:mainfrom
Open
Update rose-stem to extract MOCI and UM-related repos from Git#29ericaneininger wants to merge 2 commits intoMetOffice:mainfrom
ericaneininger wants to merge 2 commits intoMetOffice:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Code Reviewer: @Pierre-siddall
Update MOCI rose-stem suite to pull from Git repositories for MOCI plus UM (and related repos).
Add shutdown handler to run
suite_reportto gain atrac.logfile. Please note, thesuite_report_git.pyscript called, which resides in the SimSys_Scripts repo, currently defaults to UM as primary source - hence slightly peculiar title in the report!New lib/python directory is a direct copy from the UM rose-stem
Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
readability of the code
Testing
acceptable (eg. kgo changes)
tests, unit tests, etc.)
Test Suite Results - um - TEST_mociRS/run1
Suite Information
Task Information
✅ succeeded tasks - 116
Security Considerations
Performance Impact
performance measurements have been conducted
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy
(including attribution labels)
Documentation
confirmed that it builds correctly
Code Review