-
Notifications
You must be signed in to change notification settings - Fork 1
Circuit Browser Fixes for #VFB-223 and #VFB-224 #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…24 Stack viewer not working properly when opening another template from the term info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses two stack viewer issues: cleanup after image resizing (#VFB-223) and proper handling when opening templates from term info (#VFB-224). The changes refactor URL parameter handling, fix tile calculations by removing incorrect scaling, and improve template domain configuration management.
Key Changes:
- Refactored URL parameter processing logic to handle instance loading order and focus more cleanly
- Fixed tile calculation to remove incorrect division by 10 and scaling that caused resize cleanup issues
- Enhanced template domain configuration with explicit field names instead of array indices
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| urlUpdaterMiddleware.js | Refactored instance loading logic from URL parameters with cleaner queue management and focus determination |
| StackViewerComponent.jsx | Fixed tile calculations for proper resizing, improved wheel listener setup with null checks, and refactored subdomain configuration handling |
| StackViewer.jsx | Enhanced config structure with explicit template domain fields and improved domain array initialization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
applications/virtual-fly-brain/frontend/src/components/StackViewerComponent.jsx
Outdated
Show resolved
Hide resolved
applications/virtual-fly-brain/frontend/src/components/StackViewerComponent.jsx
Show resolved
Hide resolved
applications/virtual-fly-brain/frontend/src/components/StackViewerComponent.jsx
Show resolved
Hide resolved
applications/virtual-fly-brain/frontend/src/reducers/middleware/urlUpdaterMiddleware.js
Show resolved
Hide resolved
applications/virtual-fly-brain/frontend/src/reducers/middleware/urlUpdaterMiddleware.js
Outdated
Show resolved
Hide resolved
applications/virtual-fly-brain/frontend/src/reducers/middleware/urlUpdaterMiddleware.js
Show resolved
Hide resolved
… logic in StackViewerComponent
…StackViewerComponent
ddelpiano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Virtual.Fly.Brain.a.data.integrator.for.Drosophila.neurobiology.1.webm
@jrmartin I just deployed your branch (double check the dev pipeline in codefresh, just to be sure) but the stack viewer for me does not work as per video attached.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
applications/virtual-fly-brain/frontend/src/reducers/middleware/urlUpdaterMiddleware.js
Show resolved
Hide resolved
applications/virtual-fly-brain/frontend/src/reducers/middleware/urlUpdaterMiddleware.js
Show resolved
Hide resolved
applications/virtual-fly-brain/frontend/src/components/StackViewerComponent.jsx
Show resolved
Hide resolved
applications/virtual-fly-brain/frontend/src/components/StackViewerComponent.jsx
Show resolved
Hide resolved
…and simplify focus target logic
|
@ddelpiano I fixed the bug locally and deployed to dev to test, seems working now: Screen.Recording.2025-11-17.at.1.52.30.PM.mov |
…et selection logic
Fixes: #VFB-223 Stack viewer not cleaning up after resizing image and #VFB-224 Stack viewer not working properly when opening another template from the term info