Skip to content

Conversation

@jrmartin
Copy link
Collaborator

Fixes: #VFB-223 Stack viewer not cleaning up after resizing image and #VFB-224 Stack viewer not working properly when opening another template from the term info

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses two stack viewer issues: cleanup after image resizing (#VFB-223) and proper handling when opening templates from term info (#VFB-224). The changes refactor URL parameter handling, fix tile calculations by removing incorrect scaling, and improve template domain configuration management.

Key Changes:

  • Refactored URL parameter processing logic to handle instance loading order and focus more cleanly
  • Fixed tile calculation to remove incorrect division by 10 and scaling that caused resize cleanup issues
  • Enhanced template domain configuration with explicit field names instead of array indices

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.

File Description
urlUpdaterMiddleware.js Refactored instance loading logic from URL parameters with cleaner queue management and focus determination
StackViewerComponent.jsx Fixed tile calculations for proper resizing, improved wheel listener setup with null checks, and refactored subdomain configuration handling
StackViewer.jsx Enhanced config structure with explicit template domain fields and improved domain array initialization

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jrmartin jrmartin marked this pull request as ready for review November 17, 2025 15:26
@jrmartin jrmartin requested a review from ddelpiano November 17, 2025 15:27
Copy link
Member

@ddelpiano ddelpiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Virtual.Fly.Brain.a.data.integrator.for.Drosophila.neurobiology.1.webm

@jrmartin I just deployed your branch (double check the dev pipeline in codefresh, just to be sure) but the stack viewer for me does not work as per video attached.
Thanks!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jrmartin
Copy link
Collaborator Author

@ddelpiano I fixed the bug locally and deployed to dev to test, seems working now:

Screen.Recording.2025-11-17.at.1.52.30.PM.mov

@jrmartin jrmartin requested a review from ddelpiano November 17, 2025 21:54
@ddelpiano ddelpiano merged commit 6d9b30b into development Dec 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants