Skip to content

Conversation

@ccharly
Copy link
Contributor

@ccharly ccharly commented Mar 6, 2025

Just bumping deps to solve the elliptic audit error.

├─ browserify-sign@npm:4.2.3
│  └─ elliptic@npm:6.6.1 (via npm:^6.5.5)

└─ create-ecdh@npm:4.0.4
   └─ elliptic@npm:6.6.1 (via npm:^6.5.3)

"asn1.js@npm:^5.2.0":
version: 5.4.1
resolution: "asn1.js@npm:5.4.1"
"asn1.js@npm:^4.10.1":
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this have been downgraded on purpose:

# This PR:
└─ parse-asn1@npm:5.1.7
   └─ asn1.js@npm:4.10.1 (via npm:^4.10.1)
   
# main
└─ parse-asn1@npm:5.1.6
   └─ asn1.js@npm:5.4.1 (via npm:^5.2.0)

@ccharly ccharly changed the title chore: bump crypto-browserify@^3.12.1 chore: bump crypto-browserify@^3.12.1 Mar 6, 2025
@ccharly ccharly marked this pull request as ready for review March 6, 2025 15:59
@ccharly ccharly requested a review from a team as a code owner March 6, 2025 15:59
@socket-security
Copy link

socket-security bot commented Mar 6, 2025

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/asn1.js@5.4.14.10.1 unsafe 0 46.6 kB indutny
npm/browserify-rsa@4.1.04.1.1 None 0 10.7 kB ljharb
npm/browserify-sign@4.2.14.2.3 None +1 23.5 kB ljharb
npm/crypto-browserify@3.12.03.12.1 None 0 56 kB ljharb
npm/elliptic@6.5.46.6.1 None +1 216 kB indutny

View full report↗︎

@socket-security
Copy link

socket-security bot commented Mar 6, 2025

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/parse-asn1@5.1.7, npm/browserify-rsa@4.1.1, npm/crypto-browserify@3.12.1, npm/hash-base@3.0.5

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@ccharly
Copy link
Contributor Author

ccharly commented Mar 11, 2025

@SocketSecurity ignore npm/parse-asn1@5.1.7
@SocketSecurity ignore npm/browserify-rsa@4.1.1
@SocketSecurity ignore npm/crypto-browserify@3.12.1
@SocketSecurity ignore npm/hash-base@3.0.5

The new author is a contributor of many other JS projects and is a TC39 committee member.

@ccharly ccharly merged commit 9ce1edf into main Mar 11, 2025
19 checks passed
@ccharly ccharly deleted the chore/update-crypto-browserify branch March 11, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants