Skip to content

Conversation

@jiexi
Copy link
Contributor

@jiexi jiexi commented Jan 20, 2026

Explanation

  • Ensure eth_chainId is resolved by cache in the MWPTransport when hit by the EIP-1193 Provider
  • Add state getter to ConnectEvm that passes through the #core.state (ConnectMultichain) value

References

See: Web3Auth/web3auth-web#2326

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@jiexi jiexi requested a review from a team as a code owner January 20, 2026 21:46
@jiexi jiexi changed the title jl/web3auth fixes fix: Fix eth_chainId not being resolved from cache when using EIP-1193 Provider. Expose ConnectMultichain.state in ConnectEvm Jan 20, 2026
@jiexi
Copy link
Contributor Author

jiexi commented Jan 20, 2026

Might want to split these into separate PRs

Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eth_chainId changes look good to me. I agree we should split out the state getter and explain why its necessary 🤮

@adonesky1
Copy link
Contributor

adonesky1 commented Jan 20, 2026

instead of exposing the full state object should we expose a connectionStatus (or some other word for it) value instead?

@jiexi jiexi changed the title fix: Fix eth_chainId not being resolved from cache when using EIP-1193 Provider. Expose ConnectMultichain.state in ConnectEvm fix: Fix eth_chainId not being resolved from cache when using EIP-1193 Provider Jan 22, 2026
@adonesky1 adonesky1 merged commit e0ab14d into main Jan 22, 2026
46 checks passed
@adonesky1 adonesky1 deleted the jl/web3auth-fixes branch January 22, 2026 18:42
@jiexi jiexi mentioned this pull request Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants