-
-
Notifications
You must be signed in to change notification settings - Fork 3
[Examples] Update Dynamic example #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Caution MetaMask internal reviewing guidelines:
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
jeffsmale90
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
| "@metamask/smart-accounts-kit": "^0.2.0", | ||
| "@tanstack/react-query": "^5.90.6", | ||
| "next": "15.3.4", | ||
| "next": "15.4.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should update to next@15.4.10. https://nextjs.org/blog/security-update-2025-12-11
jeffsmale90
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
| <SendUserOperationButton | ||
| to={address as Address} | ||
| value={parseEther(value)} | ||
| value={isValidValue ? parseEther(value) : 0n} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this could be broken into a variable to avoid complicating the react component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have already moved the examples to https://github.com/MetaMask/smart-accounts-kit-examples
Have covered all the changes there. In Q1 first week, I'll remove examples from this repo, and rename it.
Description
Note
Migrates the Dynamic signer example to smart-accounts-kit v0.2.0 and a newer Next.js, refactoring components and app structure to the updated APIs.
examples/smart-accounts/signers/dynamic/):smart-accounts-kittov0.2.0and update Next.js.src/components/SendUserOperationButton.tsxfor the new signing/submission flow.src/components/TransactionForm.tsx,src/components/Steps.tsx, andsrc/components/Footer.tsxto the updated SDK/types.src/app/layout.tsxandsrc/app/page.tsxto align with the updated Next.js app setup.Written by Cursor Bugbot for commit 13b581a. This will update automatically on new commits. Configure here.