feat: replace `caip-x` with `caip-348` for CAIP-294 announcement and Multichain API externally_connectable protocol by jiexi · Pull Request #32070 · MetaMask/metamask-extension

jiexi · 2025-04-16T17:58:16Z

Description

Related issues

See: MetaMask/test-dapp-multichain#53
See: MetaMask/providers#413
See: MetaMask/multichain-api-client#40

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-04-16T17:58:30Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Replace `caip-x` with `caip-348` See: ChainAgnostic/CAIPs#348 See: MetaMask/metamask-extension#32070

jiexi · 2025-04-17T21:30:24Z

depends on the following being merged first

socket-security · 2025-04-17T21:38:03Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Package	Supply Chain Security	Quality	Maintenance
caniuse-lite@1.0.30001669 ⏵ 1.0.30001707	⁺¹	⁺¹
@metamask/multichain-api-client@0.2.0 ⏵ 0.3.0	^-22	^-2	^-6
@metamask/test-dapp-multichain@0.9.0 ⏵ 0.10.0			⁺¹

View full report

metamaskbot · 2025-04-18T17:09:46Z

Builds ready [0106f2b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1204 ± 56 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1204	1094	1386	56	1239	1316
			load	1042	955	1170	46	1070	1131
			domContentLoaded	1036	946	1166	46	1064	1125
			domInteractive	17	13	60	7	16	28
			firstPaint	666	138	1135	412	1049	1108
			backgroundConnect	6	4	10	1	7	9
			firstReactRender	20	16	43	4	20	28
			getState	11	5	44	7	15	28
			initialActions	0	0	1	0	0	1
			loadScripts	799	720	917	46	828	891
			setupStore	7	5	16	2	8	10
	Webpack	Home	uiStartup	2121	1703	2522	165	2253	2351
			load	1640	1322	1937	125	1729	1860
			domContentLoaded	1633	1318	1930	123	1724	1852
			domInteractive	15	11	53	9	13	44
			firstPaint	184	70	560	76	230	324
			backgroundConnect	25	9	107	15	29	55
			firstReactRender	208	54	367	116	322	358
			getState	15	4	275	27	15	32
			initialActions	3	1	6	1	3	5
			loadScripts	1628	1317	1908	122	1720	1829
			setupStore	21	6	287	38	20	33
Firefox	Browserify	Home	uiStartup	1371	1183	1688	101	1450	1532
			load	1222	1016	1567	106	1319	1383
			domContentLoaded	1222	1016	1567	106	1319	1383
			domInteractive	111	40	237	37	128	194
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	13	115	14	20	42
			firstReactRender	23	19	55	5	23	28
			getState	8	4	35	4	8	19
			initialActions	0	0	1	0	0	1
			loadScripts	1202	1000	1552	107	1301	1364
			setupStore	7	4	34	5	6	9
	Webpack	Home	uiStartup	1495	1286	1917	121	1568	1723
			load	1283	1109	1647	106	1358	1466
			domContentLoaded	1282	1109	1647	106	1358	1466
			domInteractive	84	44	180	25	101	136
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	81	10	21	40
			firstReactRender	34	29	45	4	36	43
			getState	8	5	30	4	8	11
			initialActions	0	0	1	0	1	1
			loadScripts	1263	1094	1627	104	1338	1444
			setupStore	9	5	50	7	8	24

Benchmark value 184 exceeds gate value 175 for chrome webpack home mean firstPaint
Benchmark value 324 exceeds gate value 310 for chrome webpack home p95 firstPaint
Benchmark value 111 exceeds gate value 110 for firefox browserify home mean domInteractive
Sum of mean exceeds: 10ms | Sum of p95 exceeds: 14ms
Sum of all benchmark exceeds: 24ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 4 Bytes (0%)
ui: 110 Bytes (0%)
common: 0 Bytes (0%)

adonesky1 · 2025-04-18T17:15:18Z

CHANGELOG.md

 - Support for Solana Devnet ([#31702](https://github.com/MetaMask/metamask-extension/pull/31702))
 - [Beta] Create Solana account automatically on wallet creation or SRP import [#32038](https://github.com/MetaMask/metamask-extension/pull/32038)
 - Support for Solana on Firefox ([#32104](https://github.com/MetaMask/metamask-extension/pull/32104))
+- Update CAIP-294 wallet announcement event to include `targets` property and new `caip-348` target object ([#32070](https://github.com/MetaMask/metamask-extension/pull/32070))


do we link the providers PR here too?

adonesky1

LGTM

replace caip-x with caip-348

090adb6

metamaskbot added the team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead label Apr 16, 2025

jiexi added a commit to MetaMask/test-dapp-multichain that referenced this pull request Apr 16, 2025

feat: Replace caip-x with caip-348 (#53)

e4b7c49

Replace `caip-x` with `caip-348` See: ChainAgnostic/CAIPs#348 See: MetaMask/metamask-extension#32070

bump relevant packages

0cf0987

Merge branch 'main' into jl/replace-caip-x-with-caip-348

38f1c9a

Merge branch 'main' into jl/replace-caip-x-with-caip-348

b8dd189

jiexi changed the title ~~WIP: replace caip-x with caip-348~~ feat: replace caip-x with caip-348 for CAIP-294 announcement and Multichain API externally_connectable protocol Apr 18, 2025

update changelog

0106f2b

adonesky1 reviewed Apr 18, 2025

View reviewed changes

adonesky1 approved these changes Apr 18, 2025

View reviewed changes

davidmurdoch approved these changes Apr 18, 2025

View reviewed changes

jiexi added this pull request to the merge queue Apr 18, 2025

adonesky1 approved these changes Apr 18, 2025

View reviewed changes

Merged via the queue into main with commit 172c2e0 Apr 18, 2025
169 checks passed

jiexi deleted the jl/replace-caip-x-with-caip-348 branch April 18, 2025 18:40

github-actions bot locked and limited conversation to collaborators Apr 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

feat: replace `caip-x` with `caip-348` for CAIP-294 announcement and Multichain API externally_connectable protocol#32070

feat: replace `caip-x` with `caip-348` for CAIP-294 announcement and Multichain API externally_connectable protocol#32070
jiexi merged 5 commits intomainfrom
jl/replace-caip-x-with-caip-348

jiexi commented Apr 16, 2025 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

jiexi commented Apr 17, 2025

Uh oh!

socket-security bot commented Apr 17, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Apr 18, 2025

Uh oh!

adonesky1 Apr 18, 2025

Uh oh!

adonesky1 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Conversation

jiexi commented Apr 16, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

jiexi commented Apr 17, 2025

Uh oh!

socket-security bot commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

metamaskbot commented Apr 18, 2025

Uh oh!

adonesky1 Apr 18, 2025

Choose a reason for hiding this comment

Uh oh!

adonesky1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jiexi commented Apr 16, 2025 •

edited by github-actions bot

Loading

socket-security bot commented Apr 17, 2025 •

edited

Loading