Skip to content

Comments

chore: Remove MULTICHAIN_API feature flag and expose Multichain API on all build types#32351

Merged
adonesky1 merged 5 commits intomainfrom
ad/expose-multichain-api-on-all-builds
Apr 29, 2025
Merged

chore: Remove MULTICHAIN_API feature flag and expose Multichain API on all build types#32351
adonesky1 merged 5 commits intomainfrom
ad/expose-multichain-api-on-all-builds

Conversation

@adonesky1
Copy link
Contributor

@adonesky1 adonesky1 commented Apr 28, 2025

Previously the Multichain API was only available on Flask and Beta builds. Starting in 12.18.0 we are releasing the Multichain API to all build types including stable

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4779

Manual testing steps

  1. Build this branch in a normal stable build (yarn start)
  2. Go to https://metamask.github.io/test-dapp-multichain/latest/
  3. Enter your extensionId (watch video below to see where) -> Detection on stable blocked by 22.1.0 providers#420
  4. See that you're able to connect and interact with the multichain api

Screenshots/Recordings

Before

Screen.Recording.2025-04-28.at.2.44.45.PM.mov

After

Screen.Recording.2025-04-28.at.3.50.31.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@adonesky1 adonesky1 changed the title Remove MULTICHAIN_API feature flag and expose Multichain API on all b… Remove MULTICHAIN_API feature flag and expose Multichain API on all build types Apr 28, 2025
@metamaskbot metamaskbot added the team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead label Apr 28, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@adonesky1 adonesky1 changed the title Remove MULTICHAIN_API feature flag and expose Multichain API on all build types chore: Remove MULTICHAIN_API feature flag and expose Multichain API on all build types Apr 28, 2025
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 28, 2025
@adonesky1 adonesky1 force-pushed the ad/expose-multichain-api-on-all-builds branch 2 times, most recently from 162c91d to e3b5b02 Compare April 28, 2025 19:36
@adonesky1 adonesky1 added the release-12.18.0 Issue or pull request that will be included in release 12.18.0 label Apr 28, 2025
@adonesky1 adonesky1 changed the title chore: Remove MULTICHAIN_API feature flag and expose Multichain API on all build types chore: cp-12.18.0 - Remove MULTICHAIN_API feature flag and expose Multichain API on all build types Apr 28, 2025
@adonesky1 adonesky1 requested a review from jiexi April 28, 2025 20:08
@adonesky1 adonesky1 force-pushed the ad/expose-multichain-api-on-all-builds branch from c4d9422 to 9e80480 Compare April 28, 2025 21:03
@socket-security
Copy link

socket-security bot commented Apr 28, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​providers@​22.0.1 ⏵ 22.1.0991009298 +1100

View full report

@metamaskbot
Copy link
Collaborator

Builds ready [bb269c3]
UI Startup Metrics (1182 ± 70 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1182105214707012141320
load102792413226310521147
domContentLoaded102292013076210481141
domInteractive16133241627
firstPaint68277117040810371106
backgroundConnect6418279
firstReactRender20144452033
getState1353681930
initialActions004001
loadScripts78869896356815902
setupStore85142812
WebpackHomeuiStartup21321729248715622362353
load16411343207312217291833
domContentLoaded16341339206912217231829
domInteractive161161101346
firstPaint1757735464203320
backgroundConnect24980142861
firstReactRender19555391119333357
getState144295291325
initialActions316135
loadScripts16291338206712217211815
setupStore256297452338
FirefoxBrowserifyHomeuiStartup13181120179011913731573
load11771000165912012341452
domContentLoaded11761000165912012341452
domInteractive993522027113144
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2113213212034
firstReactRender22195562231
getState74253815
initialActions001001
loadScripts1159988163612012181438
setupStore6332368
WebpackHomeuiStartup14941361198312315601742
load12831155168210413541486
domContentLoaded12821154168110413531486
domInteractive82341672196126
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2514108152478
firstReactRender34285553644
getState94346929
initialActions002111
loadScripts12611116165510313331466
setupStore11526826826
Benchmark value 78 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Sum of mean exceeds: 0ms | Sum of p95 exceeds: 29ms
Sum of all benchmark exceeds: 29ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 9.33 KiB (0.18%)
  • ui: -261 Bytes (0%)
  • common: 0 Bytes (0%)

Copy link
Contributor

@jiexi jiexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's time 🚀

@adonesky1 adonesky1 enabled auto-merge April 29, 2025 02:26
@adonesky1 adonesky1 added this pull request to the merge queue Apr 29, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [66fd474]
UI Startup Metrics (1187 ± 60 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1187107213726012251321
load102994311995310571145
domContentLoaded102390911935310531138
domInteractive17135971632
firstPaint73281119939710411092
backgroundConnect74807710
firstReactRender21165772237
getState135102121728
initialActions001001
loadScripts78866896752816894
setupStore85213815
WebpackHomeuiStartup21591773257016422692405
load16741373204913717691915
domContentLoaded16681369204513517651879
domInteractive15124581339
firstPaint1816440669231319
backgroundConnect289182223264
firstReactRender21456363114324350
getState1245571425
initialActions317145
loadScripts16631368204313517641855
setupStore206174172334
FirefoxBrowserifyHomeuiStartup13421145175911614041556
load1199993158411712771418
domContentLoaded1199993158411712771418
domInteractive1024126535113168
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect18133741929
firstReactRender22195952227
getState74273810
initialActions002001
loadScripts1183982156111612631400
setupStore8420620615
WebpackHomeuiStartup15131328192411715951730
load12941145164010213801488
domContentLoaded12931144164010213801488
domInteractive86332372897129
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22155472336
firstReactRender36297963745
getState94295926
initialActions102111
loadScripts12741131161610113501470
setupStore12526026830
Benchmark value 30 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 0ms | Sum of p95 exceeds: 2ms
Sum of all benchmark exceeds: 2ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 9.33 KiB (0.18%)
  • ui: -261 Bytes (0%)
  • common: 0 Bytes (0%)

auto-merge was automatically disabled April 29, 2025 14:24

Pull Request is not mergeable

Merged via the queue into main with commit 1e7abc4 Apr 29, 2025
168 of 170 checks passed
@adonesky1 adonesky1 deleted the ad/expose-multichain-api-on-all-builds branch April 29, 2025 14:43
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2025
@DDDDDanica DDDDDanica changed the title chore: cp-12.18.0 - Remove MULTICHAIN_API feature flag and expose Multichain API on all build types chore: Remove MULTICHAIN_API feature flag and expose Multichain API on all build types Apr 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-12.18.0 Issue or pull request that will be included in release 12.18.0 team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants