Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
MULTICHAIN_API feature flag and expose Multichain API on all build types
162c91d to
e3b5b02
Compare
MULTICHAIN_API feature flag and expose Multichain API on all build typesMULTICHAIN_API feature flag and expose Multichain API on all build types
c4d9422 to
9e80480
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Collaborator
Builds ready [bb269c3]
UI Startup Metrics (1182 ± 70 ms)
Sum of mean exceeds: 0ms | Sum of p95 exceeds: 29ms Sum of all benchmark exceeds: 29ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ffmcgee725
approved these changes
Apr 29, 2025
Collaborator
Builds ready [66fd474]
UI Startup Metrics (1187 ± 60 ms)
Sum of mean exceeds: 0ms | Sum of p95 exceeds: 2ms Sum of all benchmark exceeds: 2ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
auto-merge was automatically disabled
April 29, 2025 14:24
Pull Request is not mergeable
MULTICHAIN_API feature flag and expose Multichain API on all build typesMULTICHAIN_API feature flag and expose Multichain API on all build types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the Multichain API was only available on Flask and Beta builds. Starting in 12.18.0 we are releasing the Multichain API to all build types including
stableRelated issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4779
Manual testing steps
yarn start)stableblocked by 22.1.0 providers#420Screenshots/Recordings
Before
Screen.Recording.2025-04-28.at.2.44.45.PM.mov
After
Screen.Recording.2025-04-28.at.3.50.31.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist