This repository was archived by the owner on May 12, 2022. It is now read-only.
Open
Conversation
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #11
Explanation:
I tracked a bug inside Metamasks code that creates browser-specific manifests. The idea here is to have
_base.jsonmanifest that holds manifest properties that are needed on all browsers and then also have browser-specific manifests such aschrome.json. Then, when manifest for specific browser distribution is created, these two manifests are merged into one. The problem occurs when you have array property such aspermissionsin both_base.jsonandchrome.json(browser-specific manifest). Below you can find examples of how this merge worked before, and how it works now.OLD BEHAVIOUR
NEW BEHAVIOUR
I have read the CLA Document and I hereby sign the CLA