Skip to content

Add preset for FE filter #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zonky2 merged 4 commits into from
Aug 4, 2025
Merged

Add preset for FE filter #1529

zonky2 merged 4 commits into from
Aug 4, 2025

Conversation

@zonky2
Copy link
Contributor

@zonky2 zonky2 commented Jul 30, 2025 •
edited
Loading

see #345

@zonky2 zonky2 requested a review from discordier July 30, 2025 21:06
@zonky2 zonky2 self-assigned this Jul 30, 2025
@zonky2 zonky2 added the enhancement This issue is about an enhancement (aka new feature) label Jul 30, 2025
@zonky2 zonky2 added this to the 2.4.x milestone Jul 30, 2025
@zonky2 zonky2 mentioned this pull request Jul 31, 2025
Closed
discordier
discordier requested changes Aug 1, 2025
View reviewed changes
src/CoreBundle/Contao/Hooks/FilterContentElementCallback.php Outdated
namespace MetaModels\CoreBundle\Contao\Hooks;

use Contao\DC_Table;
use MetaModels\CoreBundle\Contao\Hooks\AbstractContentElementAndModuleCallback;
Copy link
Member

@discordier discordier Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this line? We are in the same namespace and it seems superfluous.

Copy link
Contributor Author

@zonky2 zonky2 Aug 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also superfluous?

core/src/CoreBundle/Contao/Hooks/ContentElementCallback.php

Line 23 in 76a55a2

namespace MetaModels\CoreBundle\Contao\Hooks;

src/CoreBundle/Contao/Hooks/FilterModuleCallback.php Outdated
namespace MetaModels\CoreBundle\Contao\Hooks;

use Contao\DC_Table;
use MetaModels\CoreBundle\Contao\Hooks\AbstractContentElementAndModuleCallback;
Copy link
Member

@discordier discordier Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this line? We are in the same namespace and it seems superfluous.

Copy link
Contributor Author

@zonky2 zonky2 Aug 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also superfluous?

core/src/CoreBundle/Contao/Hooks/ModuleCallback.php

Line 21 in 76a55a2

namespace MetaModels\CoreBundle\Contao\Hooks;

@zonky2 zonky2 requested a review from discordier August 2, 2025 11:34
@zonky2 zonky2 requested a review from discordier August 4, 2025 12:05
@zonky2 zonky2 merged commit 97db777 into hotfix/2.4.4 Aug 4, 2025
4 checks passed
@zonky2 zonky2 deleted the hotfix/fix_preset_fe_filter branch August 4, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@discordier discordier discordier approved these changes

Assignees

@zonky2 zonky2

Labels

enhancement This issue is about an enhancement (aka new feature)

Projects

None yet

Milestone

2.4.x

Development

Successfully merging this pull request may close these issues.

3 participants

@zonky2 @discordier