🎨 Palette: Improve Domain Search Accessibility#103
Conversation
- switch from `on:keyup` to `on:input` for more robust search triggering - use `ReturnType<typeof setTimeout>` for correct timer typing - add `aria-label` to loading spinner - wrap search results in `role="status"` region for screen reader announcements Co-authored-by: Yeboster <23556525+Yeboster@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
💡 What:
inputevents instead ofkeyupevents.aria-labelto the loading spinner.role="status",aria-live="polite").setTimeout.🎯 Why:
on:inputensures that the search is triggered even when users paste text or use other input methods that don't fire keyup events.♿ Accessibility:
aria-label="Loading domain availability"to the circular progress indicator.role="status"andaria-live="polite"to the search result container so screen reader users are notified of search status changes.PR created automatically by Jules for task 15284288300502296841 started by @yeboster