feat(ux): improve domain search reliability and accessibility#111
feat(ux): improve domain search reliability and accessibility#111
Conversation
- Replace `on:keyup` with `on:input` for reliable search triggering. - Fix race condition where stale search results could overwrite newer ones. - Add `aria-label` to loading spinner. - Add `aria-live="polite"` region for search results to announce updates to screen readers. - Use `ReturnType<typeof setTimeout>` for better TypeScript compatibility. Co-authored-by: Yeboster <23556525+Yeboster@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
rebase |
Rebased on main and resolved conflicts. Also fixed a type error in DomainPayment.svelte caused by stricter typing. |
- Rebase on main to include requestId logic for race conditions. - Preserve aria-live and on:input improvements in DomainSearch.svelte. - Fix type mismatch in DomainPayment.svelte (unknown vs Error). Co-authored-by: Yeboster <23556525+Yeboster@users.noreply.github.com>
1 participant
💡 What: Improved the domain search functionality in DomainSearch.svelte.
🎯 Why: Users experienced unreliable search triggering on mobile/accessibility tools (due to on:keyup) and potential race conditions. Screen readers missed loading states and results.
📸 Before/After: Code changes logic for reliability.
♿ Accessibility: Added aria-label to spinner and aria-live region for results.
PR created automatically by Jules for task 15937495516180930292 started by @yeboster