🎨 Palette: Fix Dialog ARIA attributes and unique IDs#132
🎨 Palette: Fix Dialog ARIA attributes and unique IDs#132
Conversation
- Ensure Dialog `aria-labelledby` and `aria-describedby` point to existing elements by generating unique IDs based on `klass`. - Add `action="close"` to the "No" button in the confirmation dialog to ensure it functions correctly. - This improves accessibility and fixes broken ARIA references. Co-authored-by: yeboster <23556525+yeboster@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
This PR fixes an accessibility issue in the
Recordcomponent where the confirmation dialog had hardcoded IDs for its title and content, leading to broken ARIA references and duplicate IDs when multiple records were present.Changes:
klassprop.aria-labelledbyandaria-describedbyto match the generated IDs.action="close"to the cancel button.Verified with Playwright (temporary script) to confirm correct ARIA attributes are rendered.
PR created automatically by Jules for task 9889740476482371841 started by @yeboster