Fix: zap in dammv2 missing instructions sysvar #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangyro
commented
Jan 14, 2026
| expect(result).instanceOf(TransactionMetadata); | ||
| }); | ||
|
|
||
| it("zap in without external swap with rate limiter and remaining accounts", async () => { |
Collaborator
Author
There was a problem hiding this comment.
Testing without external swap since we're validating for single_swap and the external swap would result in multiple swap
bangyro
commented
Jan 14, 2026
| position, | ||
| positionNftAccount, | ||
| preSqrtPrice: poolState.sqrtPrice, | ||
| maxSqrtPriceChangeBps: U32_MAX.toNumber(), |
Collaborator
Author
There was a problem hiding this comment.
The price change ends up really big. Putting it to max avoids the tx from erroring out due to slippage.
andrewsource147
deleted the
fix/zap-in-dammv2-missing-instructions-sysvar
branch
andrewsource147
added a commit
that referenced
this pull request
Jan 19, 2026
* Fix: dammv2 fee by market cap (#40) * feat: bump damm-v2 to 0.1.6 * fix: type expected by calculate_transfer_fee_excluded_amount * feat: market cap fee mode * fix: use rev instead of branch * fix: take sqrt_price from pool instead of passing in * fix damm v2 no-entrypoint package * update damm v2 package * feat: update damm_v2 artifacts * fix: update damm_v2 tests --------- Co-authored-by: Andrew Nguyen <cuong.hv.dtvt@gmail.com> * fix fee by market cap damm-v2 * Feat/bump version 0.2.1 in cargo.toml (#43) * feat: bump cargo version * docs: update pr number * fix: typo * Fix: zap in dammv2 missing instructions sysvar (#44) * fix: add remaining accounts * feat: update damm_v2 to 0.1.7 * docs: update changelog --------- Co-authored-by: bangyro <229454856+bangyro@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.