Open
Conversation
…hey are saved into the labels field of the issues_ext_github database'. To be tested.
…ey are saved into the 'labels' field of the 'issues_ext_github database' (and not the 'bug_type' field of the 'issues' table). Fixes MetricsGrimoire#154.
…nto issue_labels
|
This has been open for quite some time. Is it possible to get it reviewed and merged? : ) Thanks! |
Member
|
Bicho is (AFAIK) no longer maintained. Many of us that used MetricsGrimoire / Bicho have moved to GrimoireLab, which in many senses is the next generation of it. In any case, I'm pinging @sduenas just in case he finds some spare cycles to consider this pull request. Thanks! |
|
Thanks for the update, @iganchevup8. Much appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code fixes #154. All the labels are retrieved (instead of only the first one in current master) and then are saved in a coma separated list into the 'labels' column of 'issues_ext_github' table (instead of 'bug_type' column of 'issues' table).
Tested with the Logstash repository and it gets no errors. Please review and comment.