-
Notifications
You must be signed in to change notification settings - Fork 48
unify save/load to policy_spec.json based folders
#4347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/mettagrid/python/src/mettagrid/util/uri_resolvers/schemes.py
Outdated
Show resolved
Hide resolved
packages/mettagrid/python/src/mettagrid/util/uri_resolvers/schemes.py
Outdated
Show resolved
Hide resolved
…emes.py Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
| @@ -0,0 +1,131 @@ | |||
| from __future__ import annotations | |||
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similarly, can we put all the custom saving/loading into CheckpointPolicy. load_policy_data and CheckpointPolicy.save_policy_data? It would dump (and load) more than just the weights file
Contributor
Author
|
closing for #4502 |
auto-merge was automatically disabled
December 22, 2025 22:34
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
save/load works both on single GPU machine and multi-gpu machine.
Unifies checkpoint save/load around policy_spec bundles (directory with policy_spec.json + weights.safetensors) while keeping a minimal .mpt compatibility path via MptPolicy in metta. Adds bundle utilities and a CheckpointPolicy to standardize serialization, resolution, and S3 sync, and fixes submission zip creation to avoid leaking local paths.
Key Changes
Breaking Changes / Migration