Skip to content

Conversation

@relh
Copy link
Contributor

@relh relh commented Dec 22, 2025

Summary

  • add a core dummy-loss guard for unused policy outputs and remove per-loss shims
  • add Loss.policy_output_keys and union used keys in the train loop
  • refine ActionSupervised action spec handling for discrete vs continuous actions

Testing

  • not run (not requested)

Copy link
Contributor Author

relh commented Dec 22, 2025

@relh relh changed the title Cooling: remove overfit metta-cli and unused minimal option in setup-env github action (#4444) Add dummy loss guard and policy output key registration Dec 22, 2025
@datadog-official
Copy link

datadog-official bot commented Dec 22, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 3044eea | Docs | Was this helpful? Give us feedback!

@relh relh marked this pull request as ready for review December 22, 2025 16:13
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@relh relh enabled auto-merge December 22, 2025 16:44
@relh relh assigned subho406 and unassigned relh Dec 22, 2025
@relh relh added this pull request to the merge queue Dec 22, 2025
Merged via the queue into main with commit 6de61f4 Dec 22, 2025
16 checks passed
@relh relh deleted the rb-stack-1-dummy-keys branch December 22, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants