Skip to content

Conversation

@relh
Copy link
Contributor

@relh relh commented Dec 24, 2025

Summary

  • Default the agent obs shim to ignore inventory power tokens (inv:*:pN) and remap feature IDs to legacy ordering
  • Restore legacy inventory normalization (100.0) for those remapped features
  • Fix power-token detection regex so the shim is effective

Why

Inventory power tokens introduced in #4356 shifted feature IDs and broke older policies trained on the pre-split inventory encoding. We only care about counts up to 255 for agents, so remapping to the legacy scheme restores compatibility.

Changes

  • ObsShimTokens now defaults ignore_inventory_power_tokens=True
  • Power-token names are detected correctly and remapped to UNKNOWN
  • Legacy feature ID ordering + legacy normalization restored for inventory features

Testing

  • uv run cogames run -m machina_1.open_world -c 4 -v heart_chorus -p s3://softmax-public/policies/relh.machina_bc_dinky_sup.hc.1221.10b.0.35/relh.machina_bc_dinky_sup.hc.1221.10b.0.35:v2700.mpt -e 1 -s 1000 --format json

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@datadog-official
Copy link

datadog-official bot commented Dec 24, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1b057ff | Docs | Was this helpful? Give us feedback!

@relh relh enabled auto-merge December 24, 2025 05:01
Copy link
Contributor Author

relh commented Dec 24, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@relh relh added this pull request to the merge queue Dec 24, 2025
Merged via the queue into main with commit 2826318 Dec 24, 2025
11 checks passed
@relh relh deleted the richard-ignorep1p2 branch December 24, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants