fix: clean up uv cache-keys in root pyproject.toml #4544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yatharth
force-pushed
the
yatharth/uv-cache-key-root-pyproject-toml
branch
from
e0ab0ca to
a806253
Compare
nishu-builder
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Removes three lines from
uv's cache keys in the rootpyproject.toml.These lines were no-ops today, and removing these lines should have no any impact whatsoever.
Additional context
The 3 removed lines were added in June in 00a9812 to ensure C++ changes trigger mettagrid rebuilds.
A refactor in September in dababc5 broke the references of those files. There are no files matching
metta/**/*{.cpp,.hpp}orpackages/mettagrid/BUILDin the repo. In other words, these lines are no-ops right now.Further, the lines are not necessary to keep. The root package has no compiled extensions. It's pure Python and doesn't need to watch C++ files. The root depends on
mettagridas a dependency, which watches its own files.packages/mettagrid/pyproject.tomlhas the correct cache-keys for its C++/Nim sources. When those sources change, mettagrid rebuilds due to its own cache-keys, which automatically the root package to get the updated mettagrid.