-
Notifications
You must be signed in to change notification settings - Fork 48
purge some uninteresting stats from wandb logging #4546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
metta/metta/rl/training/stats_reporter.py
Lines 292 to 296 in 64ccaca
| def _build_wandb_payload( | |
| self, | |
| *, | |
| losses_stats: dict[str, float], | |
| experience: Any, |
The signature of _build_wandb_payload no longer accepts optimizer (and other hyperparameter inputs), but tests/rl/test_stats_reporter_defaults.py::test_heart_metric_zero_fill_and_preserve still invokes it with optimizer=. That test now raises TypeError: _build_wandb_payload() got an unexpected keyword argument 'optimizer', so the suite fails and any callers using the previous API will break. Please either restore compatibility or update the call sites/tests to match the new signature.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Reduce training/environment stats volume and simplify StatsReporter output. This trims low‑value metrics, removes weight/dormant‑neuron reporting, and narrows rolling averages to a small set of required env metrics.
Why
We’re intentionally cutting noisy or redundant metrics to lower logging overhead and make dashboards easier to read, while keeping core signals intact.
What changed
Environment stats production (mettagrid)
StatsTracker.Stats filtering (metta/rl/stats.py)
filter_movement_metricsnow drops:env_attributes/*env_reward_estimates/*env_timing_per_epoch/*env_timing_cumulative/*env_label_completions/*filter entry (metric no longer produced in this branch).StatsReporter (metta/rl/training/stats_reporter.py)
parameters/*payload (learning rate, epoch steps, minibatches, schedulefree extras).default_zero_metricsinstead of all env metrics.W&B logger (metta/rl/training/wandb_logger.py)
latest_losses_stats; losses now only flow through StatsReporter.System monitor (mettagrid)
Behavior / compatibility notes
Testing
Not run (stats/logging changes only).
Files touched
Asana Task