Refactoring and optimization of methods #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move class
This pull request involves refactoring the chess game logic to use a
Moveobject as parameters instead of separate coordinate parameters. The 4 parameters required for most methods are now encapsulated in a single object making the code easier to read and saving spaceCloses #78
can_move_to_square method
The the method for white and black have been merged into one by giving a parameter for the color you want to check if it can move to a square / field.
Closes #113
Optimized checkmate handling
The handle_checkmate() Method has been almost halfed by adding a color parameter and reusing the whole code. Furthermore the loop just breaks as soon as a legal escape move is found. The loop also only triggers when you are in check