Mitigate "push adds commit IDs" test flakiness #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit 43379f I configured junit to run tests in parallel to speed up verifications, but this unfortunately breaks assumptions that the functional tests make and additionally increases the odds that I'll hit GitHub's API rate limits, so I'm configuring the functional tests to run serially while leaving the global default to parallel. commit-id: I22786ee4
This is to help with avoiding hitting API rate limits commit-id: Ie7089fdb
commit-id: Ie907364d
commit-id: I48126df2
This was referenced Dec 28, 2025
Closed
Closed
Closed
Test Results164 tests 164 ✅ 54s ⏱️ Results for commit 75c01f9. ♻️ This comment has been updated with latest results. |
commit-id: I956198cc
This was failing during the functional test because it assumed there was a "fake remote" (local git repo acting as the "remote" for the test) . The functional test was using a real remote, so we need to make sure branches are deleted properly based on which mode we're in. commit-id: I740f8375
commit-id: Ib9d4f25e
commit-id: I8be43d76
I noticed the last dynamic test in this function titled "only commits in the middle missing IDs" was failing fairly consistently during functional test runs. It seems there's a delay in GitHub closing test PRs created by the previous dynamic test. Since this test reused the same titles and the titles are used as keys, it was causing a "leak" from one test into the next. I'm fixing this by ensuring the titles are unique, but I could also mitigate it by adding a delay after "remote rollback" commit-id: Ia649cdf8
MichaelSims
force-pushed
the
jaspr/main/Ia649cdf8
branch
from
91c26bc to
75c01f9
Compare
MichaelSims
force-pushed
the
jaspr/main/I8be43d76
branch
from
66596e3 to
159cd1f
Compare
DerelictMan
approved these changes
Dec 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigate "push adds commit IDs" test flakiness
I noticed the last dynamic test in this function titled
"only commits in the middle missing IDs" was failing fairly consistently
during functional test runs. It seems there's a delay in GitHub closing
test PRs created by the previous dynamic test. Since this test reused
the same titles and the titles are used as keys, it was causing a "leak"
from one test into the next. I'm fixing this by ensuring the titles are
unique, but I could also mitigate it by adding a delay after "remote
rollback"
Stack:
getOrphanedBranches prunes stale tracking branchesfunctional test #321