-
Notifications
You must be signed in to change notification settings - Fork 0
Feature update to platformio #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the build system from Arduino CLI to PlatformIO for both ESP8266 and Arduino firmware projects. The changes enable better dependency management, consistent build environments, and improved CI/CD workflows.
- Replaced Arduino CLI build system with PlatformIO configuration
- Added new PlatformIO configuration files for both firmware projects
- Updated GitHub Actions workflow to use PlatformIO instead of Arduino CLI
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Firmware_ESP8266/platformio.ini | Updated PlatformIO configuration with streamlined settings and glob patterns |
| Firmware_ESP8266/.gitignore | Added PlatformIO and VS Code build artifacts to ignore list |
| Firmware_Arduino/platformio.ini | New PlatformIO configuration for Arduino Pro Mini 8MHz build |
| Firmware_Arduino/.gitignore | Added PlatformIO and VS Code build artifacts to ignore list |
| .github/workflows/build.yaml | Completely rewritten CI workflow to use PlatformIO with matrix builds |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| [platformio] | ||
| default_envs = esp8266 | ||
| src_dir = Firmware_ESP8266 | ||
| src_dir = . |
Copilot
AI
Sep 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting src_dir to '.' may cause confusion as it changes the default PlatformIO source directory structure. Consider using the standard 'src' directory or documenting why this deviation is necessary.
| src_dir = . |
| -<*.c> | ||
| +<**/*.ino> | ||
| +<**/*.cpp> | ||
| -<**/*.c> |
Copilot
AI
Sep 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build_src_filter excludes all .c files with '-<**/*.c>'. This could prevent compilation of necessary C source files if any exist in the project. Consider being more specific about which C files to exclude or remove this filter if not needed.
| -<**/*.c> |
| src_dir = . | ||
|
|
Copilot
AI
Sep 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting src_dir to '.' may cause confusion as it changes the default PlatformIO source directory structure. Consider using the standard 'src' directory or documenting why this deviation is necessary.
| src_dir = . |
| -<**/*.c> | ||
|
|
Copilot
AI
Sep 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build_src_filter excludes all .c files with '-<**/*.c>'. This could prevent compilation of necessary C source files if any exist in the project. Consider being more specific about which C files to exclude or remove this filter if not needed.
| -<**/*.c> |
…ControlPanel into feature_update_to_platformio
No description provided.