Skip to content

Conversation

@Mickyleitor
Copy link
Owner

No description provided.

@Mickyleitor Mickyleitor requested a review from Copilot September 22, 2025 22:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the build system from Arduino CLI to PlatformIO for both ESP8266 and Arduino firmware projects. The changes enable better dependency management, consistent build environments, and improved CI/CD workflows.

  • Replaced Arduino CLI build system with PlatformIO configuration
  • Added new PlatformIO configuration files for both firmware projects
  • Updated GitHub Actions workflow to use PlatformIO instead of Arduino CLI

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
Firmware_ESP8266/platformio.ini Updated PlatformIO configuration with streamlined settings and glob patterns
Firmware_ESP8266/.gitignore Added PlatformIO and VS Code build artifacts to ignore list
Firmware_Arduino/platformio.ini New PlatformIO configuration for Arduino Pro Mini 8MHz build
Firmware_Arduino/.gitignore Added PlatformIO and VS Code build artifacts to ignore list
.github/workflows/build.yaml Completely rewritten CI workflow to use PlatformIO with matrix builds

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

[platformio]
default_envs = esp8266
src_dir = Firmware_ESP8266
src_dir = .
Copy link

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting src_dir to '.' may cause confusion as it changes the default PlatformIO source directory structure. Consider using the standard 'src' directory or documenting why this deviation is necessary.

Suggested change
src_dir = .

Copilot uses AI. Check for mistakes.
-<*.c>
+<**/*.ino>
+<**/*.cpp>
-<**/*.c>
Copy link

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build_src_filter excludes all .c files with '-<**/*.c>'. This could prevent compilation of necessary C source files if any exist in the project. Consider being more specific about which C files to exclude or remove this filter if not needed.

Suggested change
-<**/*.c>

Copilot uses AI. Check for mistakes.
Comment on lines 2 to 3
src_dir = .

Copy link

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting src_dir to '.' may cause confusion as it changes the default PlatformIO source directory structure. Consider using the standard 'src' directory or documenting why this deviation is necessary.

Suggested change
src_dir = .

Copilot uses AI. Check for mistakes.
Comment on lines 13 to 14
-<**/*.c>

Copy link

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build_src_filter excludes all .c files with '-<**/*.c>'. This could prevent compilation of necessary C source files if any exist in the project. Consider being more specific about which C files to exclude or remove this filter if not needed.

Suggested change
-<**/*.c>

Copilot uses AI. Check for mistakes.
@Mickyleitor Mickyleitor merged commit 08f564f into master Sep 22, 2025
4 checks passed
@Mickyleitor Mickyleitor deleted the feature_update_to_platformio branch September 22, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants