[DRAFT][Accessibility] Document the HighContrastChanged fallback #5300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@citelao : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Contributor
|
Learn Build status updates of commit d128401: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
citelao
changed the title
This was referenced Feb 11, 2025
stevewhims
approved these changes
Feb 11, 2025
|
It seems that while this is the correct API to use to listen to theme changes, the Changed event does not fire when switching between High Contrast themes. I filed an internal bug to track this issue Bug 56208821: ThemeSettings.Changed event does not fire when switching between High Contrast themes |
learn-build-service-prod bot
pushed a commit
that referenced
this pull request
Apr 23, 2025
…c_temp Repo sync for protected branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, WinAppSDK devs should be using
ThemeSettings.Changedto detect high-contrast changes, notAccessibilitySettings.HighContrastChanged(which depends on CoreWindow).This change documents that requirement.
See corresponding docs change on
HighContrastChanged& [issue in WinAppSDK codebase](microsoft/microsoft-ui-xaml#4163Warning
HOLD until we validate this is a complete replacement.