Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 17, 2025

Addresses namespace pollution feedback from PR #271 review comment #271 (comment)

Changes

  • tests/blessed_images/generated_blessed_images.py: Replaced from worldengine.draw import * and from worldengine.model.world import * with explicit imports of 13 drawing functions and the World class
  • pyproject.toml: Removed ruff linter exception (F403, F405) that was previously masking the wildcard import issue

Example

# Before
from worldengine.draw import *
from worldengine.model.world import *

# After
from worldengine.draw import (
    draw_ancientmap_on_file,
    draw_biome_on_file,
    draw_elevation_on_file,
    # ... 10 more functions
)
from worldengine.model.world import World

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI self-assigned this Nov 17, 2025
Co-authored-by: psi29a <1122069+psi29a@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP address feedback from review on major infra restructure PR Replace wildcard imports with explicit imports in blessed image generator Nov 17, 2025
Copilot AI requested a review from psi29a November 17, 2025 22:01
@psi29a psi29a marked this pull request as ready for review November 17, 2025 22:03
@psi29a psi29a merged commit 23ccb8b into python314 Nov 17, 2025
@psi29a psi29a deleted the copilot/sub-pr-271-again branch November 17, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants