Optimize search command for tile entities on Paper servers

[RVSkeLe]

Avoid snapshots for Chunk#getTileEntities, small benchmarks here:
Before: https://spark.lucko.me/aR0fEPSZq0

After: https://spark.lucko.me/WFTL8lDgvZ

[Phoenix616]

Thanks for the PR, while I agree with the change in general (and am surprised I didn't do this myself before) I can unfortunately not merge this with jitpack as a repo as they do not provide stable builds (or a stable service in general).

[RVSkeLe]

Thanks for the PR, while I agree with the change in general (and am surprised I didn't do this myself before) I can unfortunately not merge this with jitpack as a repo as they do not provide stable builds (or a stable service in general).

Of course, if it were up to me, I would completely abandon support for Spigot in favor of Paper. I just saw a series of plugins with the same problem and thought I'd fix it, and with a library it's much easier. Do you have any advice on which repository I could publish it to?

[Phoenix616]

Ideally any maven artifact would be published to maven central so no third-party repo is needed. Otherwise publishing it to your own webserver or to github's per-repo maven repo could work too although both come with downsides. (I also could build and publish it to my own ore if you don't want to bother with that yourself, anything but jitpack tbh)

One thing I would suggest is that you don't use a group id starting with com.github for your fork though. That triggers one of the issues witg jitpack in any project were jitpack needs to be included for some reason as it will cause jitpack to build your project even if it's provided by a different repo. (Also com.github isn't your namespace anyways so there is the potential of you running into conflicts)

For that reason it is common practice in the Java-world to either use an email address as your package name and artifcat group, or if you really want to rely on github, your github.io package (so io.github.username).

[RVSkeLe]

Noted, thanks!

[RVSkeLe]

Ok, I renamed the package to io.github and published to Maven Central, is there anything else I should do?

[RVSkeLe]

Okay, so I tried this on Spigot the other day, but it won't load because Adventure isn't shaded. My question is, should Spigot be supported by the plugin?
If not, I would simply target the Paper API and use the built-in method instead. Let me know what you think.

[Phoenix616]

You are right, I forgot that it used adventure now and with that requires Paper anyways, sorry for having you do extra work to try to support Spigot :S So simply targetting Paper API for this feature is fine if you still want to implement that.

[RVSkeLe]

First of all, don't worry, and thank you for the advice you gave me :).
Secondly, now that I look more closely, the plugin already targeted the Paper API. I don't know why I thought Spigot was still supported as it's clearly using paper-api 1.17.1, I will be fixing the PR soon