-
Notifications
You must be signed in to change notification settings - Fork 2
Add diamond veins project #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
images/makeproject/project/TODO
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you maybe add something in this file describing that this specific task is for the diamond vein project?
I know that's what it is now since it's in the PR but if we continue to use a TODO like this, I'm hoping to avoid confusion next time I have to look at it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I added the todo to keep track of remaining config tasks, now that project.xml is also updated I removed the TODO file altogether
...keproject/project/apps/diaveins/1.00/windows_x86_64__cuda__win-modern/diaveins-cuda_1.00.exe
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you clarify how the credit number was determined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also - I guess there are only 4096 unique tasks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly I took the 50k credits I saw being used for loneliest seed and scaled it down arbitrarily to account for shorter tasks, I'll benchmark the tasks and estimate credits based on that instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be 65k tasks though, each task does 4096 internal cuda jobs if i understand this correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did we determine the fpops est/bound?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fpops/delay bound were just copied 1:1 from another project, estimate was based on a scuffed benchmark, I'll run the benchmark properly now so that the estimate is based on actual data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok the fpops est & bound are scaled relative to repeatdecor values now: diaveins task takes around 2.08x as long as repeatdecor on my machine so I multiplied credits, fpops bound and fpops est by that as well
Source code for binaries:
https://github.com/MinecraftAtHome/diamond-ore-veins