[7.0] Update testing setup #104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates to jUnit 6 and newer Google Compile Testing, as well as some minor cleanup.
https://github.com/junit-team/junit-framework/wiki/Upgrading-to-JUnit-6.0
The jUnit 6 upgrade was far easier than expected - they removed long-deprecated APIs, bumped the min Java to 17, switched to jSpecify, etc. All those requirements were already met so ended up being a case of bumping some numbers and confirming nothing broke.
Google in their infinite wisdom says that
com.google.testing.compile0.22.0+ needs JVM flags manually added to export JDK internals to everyone and doesn't explain why, but seems to be unnecessary for this project as far as I can tell because it works same as usual without them. The auto-value transitive dep manual version bump workaround is no longer needed though which is nice.