New build system that includes smelib#73
Open
ivh wants to merge 33 commits intoMingjieJian:masterfrom
Open
Conversation
- Replace setuptools with scikit-build-core + CMake - Build smelib from submodule (switched to MingjieJian/SMElib) - Remove runtime download/compile logic - Add GitHub Actions workflow for multi-platform wheels 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Use chocolatey to install mingw on Windows - Remove branch triggers, keep only tags and workflow_dispatch 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Extract wheel to find libsme.dll for delvewheel 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Use dependency-groups instead of optional-dependencies - Add development guide with build/release info Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add missing 'os' import in sme_synth.py - Handle array-to-scalar conversion in gaussbroad() - Add dev symlinks to .gitignore Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
libtools.py now checks both installed and source locations for data files and libraries, so development works without manual symlink setup. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- broadening.py: Convert hwhm to scalar in gaussbroad() - continuum_and_radial_velocity.py: Squeeze single-segment MCMC results Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Only include smelib/src and smelib/pymodule (what CMake needs). Avoids absolute symlinks from autotools bootstrap. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Replace ~bool with not bool (deprecated in Python 3.16) - Use go.Figure instead of go.FigureWidget when not in notebook - Fix unclosed file in persistence.py - Suppress expected divide-by-zero in MCMC probability calc
Delete versioneer, setup.py/cfg, MANIFEST.in, .isort.cfg (now using scikit-build-core with pyproject.toml). Fix CLAUDE.md and README.md to clarify that uv sync is sufficient for local dev, not uv build. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
This is a full revamp of the build system, using scikit-build-core now, and including smelib from the start, so that it does not need to be downloaded or compiled at runtime. So no more wget needed, or hardcoded call to pip, which caused error for me when running with uv instead of pip.
The wheels seem to build correctly with the updated GitHub Action, see
https://github.com/ivh/PySME/releases/tag/v0.5.0a1
I'm not suggesting that you should merge this immediately, but maybe have a look when you find the time, and let me know what you think?
cheers
/thomas