Skip to content
This repository was archived by the owner on Aug 21, 2025. It is now read-only.

Conversation

@domfournier
Copy link
Contributor

@domfournier domfournier commented Jun 19, 2025

GEOPY-2262 - Hook up plate simulation to the geoapps_utils.make_plate function

@github-actions github-actions bot changed the title GEOPY-2262 GEOPY-2262: Hook up plate simulation to the geoapps_utils.make_plate function Jun 19, 2025
@codecov
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

Attention: Patch coverage is 92.59259% with 8 lines in your changes missing coverage. Please review.

Project coverage is 90.83%. Comparing base (0d9405b) to head (a7c1a07).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
plate_simulation/models/parametric.py 89.61% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #84      +/-   ##
===========================================
- Coverage    91.84%   90.83%   -1.02%     
===========================================
  Files            8        8              
  Lines          466      480      +14     
  Branches        37       38       +1     
===========================================
+ Hits           428      436       +8     
- Misses          22       27       +5     
- Partials        16       17       +1     
Files with missing lines Coverage Δ
plate_simulation/driver.py 84.66% <100.00%> (-0.31%) ⬇️
plate_simulation/mesh/options.py 100.00% <ø> (ø)
plate_simulation/models/events.py 100.00% <100.00%> (+2.73%) ⬆️
plate_simulation/models/options.py 96.42% <100.00%> (-0.13%) ⬇️
plate_simulation/utils.py 100.00% <100.00%> (ø)
plate_simulation/models/parametric.py 89.61% <89.61%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@benk-mira benk-mira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there's some duplication with geoapps_utils.modelling.plates make_plate.. but it seems intentional - can you explain?

@domfournier domfournier merged commit b1ceab4 into develop Jun 25, 2025
14 checks passed
@domfournier domfournier deleted the GEOPY-2262 branch June 25, 2025 18:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants