[#1252] - Zappa Undeploy Fails when you have event source as Kinesis#1253
Closed
mthipparthi wants to merge 1 commit intoMiserlou:masterfrom
Closed
[#1252] - Zappa Undeploy Fails when you have event source as Kinesis#1253mthipparthi wants to merge 1 commit intoMiserlou:masterfrom
mthipparthi wants to merge 1 commit intoMiserlou:masterfrom
Conversation
Collaborator
|
Fixed on #1617 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue
When you have Kinesis as event source to trigger AWS lambda, while performing "undeploy" , we are having "Key error" and undpeloy is failing.
Not every event_resource in the zappa_settings will have "events" in it. For instance Kinesis will have no entry for "events" in the configuration. So in this case,
zappa undeployis failing as result of KeyError - 'events'. Please refer to issue [ #1252] for detailed explanation.GitHub Issues
[#1252]