Make C++ tests in testsuite link-tests only#161
Merged
dra27 merged 2 commits intoMisterDA:cxx-api-compatfrom Jan 29, 2026
Merged
Make C++ tests in testsuite link-tests only#161dra27 merged 2 commits intoMisterDA:cxx-api-compatfrom
dra27 merged 2 commits intoMisterDA:cxx-api-compatfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've got some work-in-progress changes in dra27@0363e41 to test the runtime headers as part of the development-mode build, instead of in the testsuite (it tests each header individually, in both C and C++ pedantic mode). A bit like the
config_mainandconfig_boottest module (which catches forgetting to keep utils/config.fixed.ml and utils/config.generated.ml.in in sync), it has the benefit of catching these errors during development, which means they might get caught even before a PR is opened, or at least more quickly as mostly it means the build fails, rather than the testsuite. I've tested that commit on 4 reverts of the various fixes in: dra27#265, dra27#266, dra27#267 and dra27#268.If we end up doing that, my suggestion is to keep both of the C++ tests in the testsuite, but use them as linking tests... i.e. I think your existing sockaddr compat test is obviously still worth running in C++ mode and I think it's worth having a general linking test for a C++ program testing both the bytecode and native linking.
I wasn't expecting it to end up this way, but at the moment the SARIF stuff does appear avoidable for now - but that led to wanting to share
cxx.shbetween both C++ tests, so I've proposed adding the slightly weirdoutputobjvariable to ocamltest.