Add functionality to ignore some property, related to issue #149 #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for this @ansariabr When I run the full test sweet in Visual Studio, I get some failures in our existing tests. I'm investigating but wondering if you see the same on your end. |
Author
|
@dpaquette something strange happened. While the development all the tests were passing. But after seeing your comment, I re-ran the test on my machine. I got 2 failed tests on the very first run. After that, on each execution of tests, all the tests were passing. |
Collaborator
|
Ok, I don't think it's related to your change. I think we still have some random test failures |
|
@dpaquette Why is this PR still open? Is this because some tests were failing in the local vs? |
Collaborator
|
Yeah, I needed to investigate further. Been swamped with other projects and life stuff so I haven't gotten back to it.
…________________________________
From: Krishna Mohan <notifications@github.com>
Sent: Tuesday, March 31, 2020 8:29:36 PM
To: MisterJames/GenFu <GenFu@noreply.github.com>
Cc: Paquette, David <david.paquette@usask.ca>; Mention <mention@noreply.github.com>
Subject: Re: [MisterJames/GenFu] Add functionality to ignore some property, related to issue #149 (#157)
CAUTION: This email originated from outside of the University of Saskatchewan. Do not click links or open attachments unless you recognize the sender and know the content is safe. If in doubt, please forward suspicious emails to phishing@usask.ca
@dpaquette<https://github.com/dpaquette> Why is this PR still open? Is this because some tests were failing in the local vs?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#157 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AATKEI5VP6GPTRMFA4PUZPLRKKRJBANCNFSM4KOYBYFQ>.
|
|
Need any help on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix issue #149