solana multisig #97
Draft
solana multisig #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndling, and network loops for deposits and approvals. Update existing methods to accommodate Solana transactions and enhance error handling.
- Introduced a new configuration field `SolanaPayer` in the observer's interface for Solana transactions. - Updated the transaction signing process in `solana.go` to utilize the new `SolanaPayer` configuration for signing transactions. These changes enhance the Solana transaction handling capabilities of the observer.
- Added a new method `RPCGetAsset` to fetch asset details using its address, including mint information and metadata. - Introduced a new struct `AssetMetadata` to hold asset metadata such as symbol and name. - Implemented a helper method `getAssetMetadata` to retrieve asset metadata via RPC call. These changes enhance the asset management capabilities of the Solana RPC client.
- Added a new function `ValidateTransactionSignatures` in `transaction.go` to ensure that the number of signatures matches the required count and that all signatures are valid and non-zero. - Updated the `processSolanaSafeApproveAccount` method in `solana.go` to correctly set the state to `SafeStateApproved`. - Enhanced the test coverage for Solana transactions by introducing a new test file `solana_test.go`, which includes comprehensive tests for transaction proposals, approvals, and network status updates. - Modified existing tests in `keeper_test.go` to accommodate changes related to Solana transaction handling. These changes improve the robustness and reliability of Solana transaction processing and validation.
- Deleted the `account_test.go` file for Bitcoin, which contained various tests for Bitcoin-related functionalities. - Introduced a new `account_test.go` file for Solana, implementing tests for public key verification and random key generation. - Updated the Solana account handling in the codebase to enhance testing and functionality. These changes streamline the testing framework by focusing on Solana while removing outdated Bitcoin tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.