Skip to content

Updated gamekit to ios 10.1#77

Merged
florianf merged 4 commits intoMobiVM:masterfrom
piotr-j:master
Dec 3, 2016
Merged

Updated gamekit to ios 10.1#77
florianf merged 4 commits intoMobiVM:masterfrom
piotr-j:master

Conversation

@piotr-j
Copy link
Contributor

@piotr-j piotr-j commented Nov 12, 2016

Ive updated gamekit.yaml based mainly on last @CoderBaron pr. Added new apis and updated marshaler stuff mainly. Probably horribly broken.

@piotr-j piotr-j changed the title Updated gamekit Updated gamekit to ios 10.1 Nov 12, 2016
@florianf
Copy link
Collaborator

Great, thanks a lot! You finally mastered bro-gen ;-) I'll take a look in the next days.

@piotr-j
Copy link
Contributor Author

piotr-j commented Nov 13, 2016

Some comments ive left in the yaml might say otherwise

@florianf
Copy link
Collaborator

Status of this PR: Currently there are several methods generated with a trailing $. Also existing methods have now a trailing $, f.ex https://github.com/MobiDevelop/robovm/pull/77/files#diff-330dffcf484bb1b7eb9cca46e810aea8R87

We need to resolve this issue in https://github.com/CoderBaron/robovm-bro-gen or find a workaround. Any help appreciated.

@piotr-j
Copy link
Contributor Author

piotr-j commented Nov 25, 2016

Ive fixed the all $ and invalid @since versions. Versions require this pr for proper generation.

@florianf
Copy link
Collaborator

florianf commented Nov 27, 2016

@piotr-j Thanks for the update. I got compile errors with classes extending NSError: GKError, GKSessionError and GKVoiceChatServiceError:
Implicit super constructor NSError() is undefined. Must explicitly invoke another constructor

The current implementation looks a bit different:
https://github.com/MobiDevelop/robovm/blob/master/compiler/cocoatouch/src/main/java/org/robovm/apple/gamekit/GKError.java

All those classes need to implement the NSError(SkipInit skipInit) constructor, than it works.

Furthermore it seems the GKErrorCode class needs to implement NSErrorCode: https://github.com/MobiDevelop/robovm/blob/master/compiler/cocoatouch/src/main/java/org/robovm/apple/gamekit/GKErrorCode.java

When I change those things manually, it builds fine, can we get this automagically from bro-gen, at least the constructors and extension of NSErrorCode?

@piotr-j
Copy link
Contributor Author

piotr-j commented Nov 27, 2016

Ah yes, Ive totally forgot about this. Ive had to modify those manually in previous commits.
Ill take another look, maybe with more luck this time.

@florianf florianf merged commit c65eba4 into MobiVM:master Dec 3, 2016
@florianf
Copy link
Collaborator

florianf commented Dec 3, 2016

@piotr-j Merged it and fixed those things manually. Thanks for your work, it's appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants