Add logic test support #555
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Very cool! This seems like it'd satisfy #531 |
Author
Yes! Very excited to support this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds logic test support to Bluepill, so that unit tests can be run without an app host. Resolves #531.
Leverages CoreSimulator's private
spawnmethod to run the xctest executable on individual logic test bundles. Doing so requires adjustments to various inputs (e.g. the xctest executable expects the list of tests in a different format) as well as different error handling (based on the nuances of how errors/crashes surface from thespawnmethod.Also fixes a bug where retrying tests after a crash was being dictated by the wrong config variable (
onlyRetryFailedrather thanretryAppCrashTests).Tests were added to validate:
Logic test execution time data was collected and available here.
Note: should be tested with consuming app (Voyager iOS) before committing, which requires a pending change in that app first. In the mean time, this change is only internally tested.