Remove Apache Commons Lang and unnecessary Guava usages#25
Open
MrMicky-FR wants to merge 10 commits intoMojang:masterfrom
Open
Remove Apache Commons Lang and unnecessary Guava usages#25MrMicky-FR wants to merge 10 commits intoMojang:masterfrom
MrMicky-FR wants to merge 10 commits intoMojang:masterfrom
Conversation
RainWarrior
suggested changes
Oct 11, 2018
kashike
suggested changes
Oct 11, 2018
hugmanrique
reviewed
Oct 13, 2018
Author
|
Hi, any updates on this @RainWarrior ? |
Marcono1234
reviewed
May 31, 2020
Marcono1234
left a comment
Marcono1234
left a comment
There was a problem hiding this comment.
Note that org.apache.commons.lang3.tuple.Triple is an abstract class and subclasses may be mutable, while the newly added Triple is immutable. However, that is probably fine since Minecraft only uses the immutable implementation?
Contributor
|
Closing and reopening to rerun checks. |
Author
|
More than 4 years, that's a while! @peterix I've resolved the merge conflicts and the build/tests run locally for me, just the GitHub Actions workflow is awaiting approval from a maintainer :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lists.newArrayList()that can be replace with justnew ArrayList<>()