Update samplesheet_processing samplesheet to have demultiplexer name #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problems does this PR solve?
This version updates the samplesheet name in the snpseq-tester container to contain the demultiplexer name.
This is because both bcl2fastq and bclconvert samplesheets will be generated and need to be differentiated.
How has the changes been tested?
Deleted old image and did docker/up a fresh and tested with the stackstorm test_workflows to ensure the correct mounted samplesheet is retrieved and informative message is given if the samplesheet with the demultiplexer name is not found.
Reasons for careful code review
If any of the boxes below are checked, extra careful code review should be inititated.